On Sun, 19 Jun 2022 16:13:00 -0400, Gabriel Filion wrote: > I've created a new package for InfluxDB::HTTP as the libinfluxdb-http-perl > package and I don't have DM or DD access. I think that it should be mostly > ready for review. > https://salsa.debian.org/perl-team/modules/packages/libinfluxdb-http-perl Nice to see your first package coming along :) > Can I gently ask for some help with reviewing my work on this package? Some notes: - I wouldn't install the README.pod as it is the same as the POD (and the manpage) % diff -u <(pod2text README.pod) <(pod2text lib/InfluxDB/HTTP.pm) `perldoc InfluxDB::HTTP' and `man InfluxDB::HTTP' should be enough :) - W: libinfluxdb-http-perl source: no-nmu-in-changelog W: libinfluxdb-http-perl source: source-nmu-has-incorrect-version-number 0.04-1 That's because you use a different mail adress in d/control and d/changelog. - I: libinfluxdb-http-perl: synopsis-is-a-sentence "Perl way to interact with InfluxDB." --> remove full stop at the end - I: libinfluxdb-http-perl: typo-in-manual-page usr/share/man/man3/InfluxDB::HTTP.3pm.gz line 151 reponse response Upstream might be happy about a patch :) > One detail that I left out: there's a t/ directory with one file that > contains tests. I've tried to add build-deps for running the test suite but > I ended up needing another library, Object::Result, which is not packaged in > Debian and I didn't want to fall into a rabbit hole. So for now the package > does not run tests with autopkgtest. Now that is interesting; typically we have t/*.t or the old test.pl, but t/test.pl is something, hm, unusual. And it's not run during build (and would probably need a running influxd …) So you can also remove the libtest-simple-perl build dependency (coming from META.*; not that this changes anything, as it's provided by src:perl). As for autopkgtests, I'd still add the "Testsuite: autopkgtest-pkg-perl" field, as there are more tests than running the smoke tests. And they work. "Work" not in "pass" but in the sense of "find an issue" :) # Can't locate JSON/MaybeXS.pm in @INC (you may need to install the JSON::MaybeXS module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 13. So libjson-maybexs-perl is missing in Depends (and the upstream metadata). Next one: # Can't locate LWP/UserAgent.pm in @INC (you may need to install the LWP::UserAgent module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 14. So let's add libwww-perl to Depends. And let's look at the actual code: use JSON::MaybeXS; use LWP::UserAgent; use Object::Result; use URI; We have liburi-perl but *drumroll* we're back to packaging Object::Result which you wanted to avoid :) I added a note to d/changelog. Some more details: * I've added a debian/upstream/metadata file (dh-make-perl didn't find the github repo but lintian-brush did). * d/control: Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org> Uploader: Gabriel … Vcs-Browser: https://salsa.debian.org/perl-team/modules/packages/libinfluxdb-http-perl Vcs-Git: https://salsa.debian.org/perl-team/modules/packages/libinfluxdb-http-perl.git (dh-make-perl has a --pkg-perl option) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `-
Attachment:
signature.asc
Description: Digital Signature