Re: Bug#963727: dh-make-{elpa,perl}: move duplicate code to a library

[Lev Lamberov <dogsleg@debian.org>]

Hi gregor,

Mon 23 May 2022 @ 16:54 gregor herrmann <gregoa@debian.org>:

> On Fri, 26 Jun 2020 11:38:48 +0500, Lev Lamberov wrote:
>
>> Hi,
>
> Sorry for replying so late, somehow this bug fell throught the
> cracks.
>  
>> dh-make-elpa is heavily based on dh-make-perl (thanks to all who
>> were/are involved into whis nice tool). Both share the same
>> object-oriented structure and some code. Recently, dh-make-elpa was
>> untied from dh-make-perl, so now the former doesn't depend on the
>> latter. But this was done by copying some code from dh-make-perl without
>> changes. The better option would be to move duplicate code to a library.
>
> Makes sense.
>
>> It would be nice to identify those methods which may be useful for
>> various (possible) implementations of dh-make-<something> and are
>> unlikely to change significantly in the future. Those methods could be
>> moved to, say, DhMake::Packaging.
>
> Agreed.
>  
>> I would like to implement changes for both dh-make{elpa,perl}, but first
>> we should discuss what should be done and in which way. So, CCing Debian
>> Perl Group mailing list, but I think that it's better to keep the
>> discussion in one place, that is, in this bug report.
>
> From a dh-make-perl perspective I think we are happy with everything
> which "only" moves functionality around without breaking anything.
> So if you are still planning to work on this task, please go ahead
> and send patches/merge requests.

Thanks for the update. Hope, I will have some time during the coming
summer.

Cheers!
Lev