[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for review etc of libmodule-install-substitute-perl

On Sat, 2020-11-28 at 02:21 +0100, gregor herrmann wrote:
> On Sat, 28 Nov 2020 12:42:34 +1300, Andrew Ruthven wrote:
> > > >  * add missing debian/upstream/metadata
> > I've created as much of this as I can.
> > Also, could dh-make-perl generate some of the contents of this
> > file?
> It does, but only if upstream provides the data :)

Ah ha!

> (And basically we use debian/upstream/metadata only for the upstream
> Git repo. But looking at the file you created taught me some new keys
> I haven't seen before :))

For reference, I used https://wiki.debian.org/UpstreamMetadata as a
guide for the keys to use.

Sadly I couldn't find a git (or any other VCS) repo for the package. :(

> dpt-debian-upstream also creates debian/upstream/metadata (but again
> only if the information is in META.{yml,json}). Oh, and lintian-brush
> as well (not sure where it looks).

Oh, nice.

> > > Also : "X: perl-module-name-not-mentioned-in-description
> > > Module::Install::Substitute"
> > Fixed.
> This lintian tag is more about the long description in
> debian/control,
> and not about the upstream POD. - Unsurprisingly, lintian still
> finds:
> X: libmodule-install-substitute-perl: perl-module-name-not-mentioned-
> in-description Module::Install::Substitute

Ah, I misinterpreted that, and I didn't realise I needed to run lintian
with -E to see that warning so I thought I had fixed it.


> And then (re your other patch) lintian now also tells us:
> P: libmodule-install-substitute-perl source: spelling-error-in-patch-
> description debian/patches/add-name-to-description.diff grammer
> grammar

Doh. Fixed.
> > Perhaps this is something that dh-make-perl can insert in these
> > circumstances as well?
> That's a bit hard to do [0] but if you have ideas: you have the
> commit
> bit for dh-make-perl as well :)

Yeah, fair point.


Andrew Ruthven, Wellington, New Zealand
andrew@etc.gen.nz              |
Catalyst Cloud:  | This space intentionally left blank
https://catalystcloud.nz |

Reply to: