On Tue, 21 Jul 2020 19:02:12 +1200, Andrew Ruthven wrote: > GnuPG::Interface made a change to handle both GnuPG version 1.4 and 2.2 > and it does that by tracking the version of gpg that is being used. But > it failed to clear the cached version information if you changed the > gpg binary to use after the object was instantiated. > > This is exactly how Request Tracker changes the gpg binary to use with > GnuPG::Interface, and caused request-tracker4 to FTBFS. Thanks for your investigations and your work on this! > I've pushed a commit to libgnupg-interface-perl which resolves this > behaviour. We also now test libgnupg-interface-perl against both > versions of GnuPG. > > If someone could please review and (hopefully) upload the package, > that'd be much appreciated. Looks good to me in general. Some thoughts: - Does this also fix #964878? - Could you forward the relevant patches upstream (to the CPAN RT issue)? Then we can wait a bit and see if there are reactions before uploading. - The tests throw some warnings: t/import_keys.t ............ 1..2 ok 1 ok 2 ok Can't exec "gnupg": No such file or directory at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 343. Use of uninitialized value $a in split at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1. Use of uninitialized value $a in split at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1. t/Interface.t .............. 1..2 ok 1 ok 2 ok … t/import_keys.t ............ 1..2 ok 1 ok 2 ok Can't exec "gnupg": No such file or directory at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 343. Use of uninitialized value $a in split at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1. Use of uninitialized value $a in split at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1. t/Interface.t .............. 1..2 ok 1 ok 2 ok (So the same for gpg2 and gpg1). Is this expected/harmless/…? - Same in autopkgtests: t/Interface.t .............. 1..2 ok 1 Can't exec "gnupg": No such file or directory at /usr/share/perl5/GnuPG/Interface.pm line 343. Use of uninitialized value $a in split at /usr/share/perl5/GnuPG/Interface.pm line 829, <GEN5> line 1. Use of uninitialized value $a in split at /usr/share/perl5/GnuPG/Interface.pm line 829, <GEN5> line 1. ok 2 ok - Not sure if CALL is the nicest possible name for the env var but that's bikeshedding territory :) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: R.E.M.: Daysleeper
Attachment:
signature.asc
Description: Digital Signature