On Fri, 24 Apr 2020 01:32:06 +0200, Xavier wrote:
(moving to the list)
Background: a package which would need an environment variable for
the use.t test, or the new restriction.
> Le 24/04/2020 à 01:04, gregor herrmann a écrit :
> > On Thu, 23 Apr 2020 21:47:12 +0200, Xavier wrote:
> >
> >>>> Not sure how much point there is to the test after that though...
> >>> I guess taking this route allows for more testing than completely
> >>> skipping.
> >> there is now a "needs-internet" restriction in autopkgtest.
> >
> > Right, and thanks for mentioning it.
> >
> > But I'd rather avoid this new restriction in general, as internet
> > tests are per se unreliable (as they depend on "something else", like
> > a server being up etc.), and in a specific file we would need to
> > create a separate d/t/control and then update it whenever autodep8
> > changes.
> >
> Maybe something like http://paste.debian.net/1142536/ in autodep8 ?
Copying here for posterity:
#v+
#!/bin/sh
cat <<EOF
Test-Command: /usr/share/pkg-js-autopkgtest/runner require
Depends: @, nodejs, pkg-js-autopkgtest
Restrictions: superficial
Features: test-name=pkg-js-autopkgtest-require
EOF
if test -e debian/tests/pkg-js; then
RESTRICTIONS="allow-stderr, skippable"
if test -e debian/tests/pkg-js/net; then
RESTRICTIONS="$RESTRICTIONS, needs-internet"
fi
cat <<EOF
Test-Command: /usr/share/pkg-js-autopkgtest/runner
Depends: @, @builddeps@, pkg-js-autopkgtest
Restrictions: $RESTRICTIONS
Features: test-name=pkg-js-autopkgtest
EOF
fi
#v-
I'm not sure if this is brilliant or horrible :)
But yeah, the idea of changing the test requirements by touching files in
debian/tests/pkg-perl is an option; or adding a "config file" there;
etc.
I remember that Niko had ideas about changing the framework of our
tests (as the "runner" which picks tests in different subdirectories
is not really needed since we have autodep8), so maybe we can all
discuss this together, and maybe at our next (online) sprint?
Cheers,
gregor
--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Joan Baez: The Boxer
Attachment:
signature.asc
Description: Digital Signature