[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#946718: gbrowse: autopkgtest regression: Can't call method "features" on an undefined value



On Tue, 17 Dec 2019 13:49:24 +0100, gregor herrmann wrote:

I had a chance to look at the actual package now, which is more
helpful than hand-waving advice, and here are my results:

> It looks like t/05.deferredrendering.t wants conf/ (in addition to t/
> and sample_data/) in debian/tests/pkg-perl/smoke-files. But
> interestingly it doesn't fail.

Adding conf/ is not enough to make t/05.deferredrendering.t pass; and
I'm not sure how to get this working but as the test isn't failing I
guess we can ignore this.
 
> So why does t/00.compile.t fail? (And, BTW, we all missed that it
> also failed in -5.)
> 
> Looking at https://salsa.debian.org/med-team/gbrowse/blob/master/t/00.compile.t
> I see "use lib "install_util";" in line 4.
> So maybe adding install_util/ to debian/tests/pkg-perl/smoke-files is
> enough.

This is not needed but …
 
> But probably not; after a quick look it tries to check files in bin/ and
> cgi-bin/. If I'm reading this correctly …
> Hm, so maybe adding also bin/ and cgi-bin/ would work. But I'm not
> sure, and testing the scripts from the source tree (and not the
> installed ones) is a bit pointless.

… adding bin/ and cgi-bin/ to debian/tests/pkg-perl/smoke-files
works.
 
> So an alternative is to skip t/00.compile.t:
> echo t/00.compile.t > debian/tests/pkg-perl/smoke-skip

This of course works as well (with >> as the file exists :))
 

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: STS: Immer weiter fort

Attachment: signature.asc
Description: Digital Signature


Reply to: