[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: (one link added) Re: Please help me review patches for mime-support.



On Sat, 02 Feb 2019 13:36:14 +0900, Charles Plessy wrote:

> > 3 years ago (sorry Eliott for the delay !), I have received patches to
> > strengthen some of the mime-suppport programs.
> 
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=783195

That's probably ok; I just note that run-mailcap has a couple more
occurances of the incorrect
    $res = int($res/256);
which should probably fixed as well.

> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=803729

'use strict;' and 'use warnings;' are obviuosly a Good Idea™.

> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=803996

Hm, that's less a question of perl coding and more of program logic.
It doesn't look insane but I haven't read the whole code or tried to
understand the used state machine.

Maybe this still helps a bit.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Rolling Stones: Vletsgosteady

Attachment: signature.asc
Description: Digital Signature


Reply to: