On Thu, 07 Sep 2017 01:09:46 +0200, Alex Muntada wrote:
> > As I mentionded yesterday, the fact that we can't run the (whole)
> > test suite during the package build makes me a bit uncomfortable.
> While grooming my backlog I found this thread and I just tested
> with autopkgtest that the package I built passes all tests.
> Can you please see if you still get failures for the tests?
Thanks for coming back to this old thread.
For me, I still see test failures during build (which are currently
ignored in debian/rules), and for autopkgtest:
autopkgtest [22:31:39]: test command1: /usr/share/pkg-perl-autopkgtest/runner build-deps
autopkgtest [22:31:39]: test command1: [-----------------------
autopkgtest [22:31:39]: test command1: -----------------------]
autopkgtest [22:31:39]: test command1: - - - - - - - - - - results - - - - - - - - - -
command1 PASS
because of:
% cat debian/tests/pkg-perl/SKIP
# needs kernel modules and sound devices
smoke
So yeah, autopkgtests "pass" because the smoke tests are skipped :)
If I remove debian/tests/pkg-perl/SKIP, the smoke tests looks like
this:
autopkgtest [22:34:29]: test command1: /usr/share/pkg-perl-autopkgtest/runner build-deps
autopkgtest [22:34:29]: test command1: [-----------------------
Nothing to prove, skipping.
1..57
ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory
can't open sequencer
# To run all tests, four virmidi clients are needed...
# You might need to add the line:
# modprobe snd_virmidi enable=1 # to create 4 virmidi ports
# to your /etc/rc.local :-)
ok 1 - inputpending() with no client returned undef
ok 2 - parse_address('97:3') with no client returned 97,3
ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory
Error creating ALSA client.
not ok 3 - client('testpl pid=5892',2,2,1)
# Failed test 'client('testpl pid=5892',2,2,1)'
# at ./test.pl line 33.
Use of uninitialized value in addition (+) at /usr/lib/x86_64-linux-gnu/perl5/5.26/MIDI/ALSA.pm line 215.
not ok 4 - id() returns 0
# Failed test 'id() returns 0'
# at ./test.pl line 39.
Use of uninitialized value $cl in numeric eq (==) at ./test.pl line 42.
Use of uninitialized value $po in concatenation (.) or string at ./test.pl line 42.
ok 5 - parse_address('testpl pid=5892') returns 0,
Use of uninitialized value $cl in numeric eq (==) at ./test.pl line 47.
Use of uninitialized value $po in concatenation (.) or string at ./test.pl line 47.
ok 6 - parse_address('testpl') returns 0,
ok 7 - can't see a virmidi client, so skipping connectfrom()
ok 8 - connectfrom(1,133,0) correctly returned 0
ok 9 - can't see two virmidi clients, so skipping connectto()
ok 10 - connectto(1,133,0) correctly returned 0
not ok 11 - start()
# Failed test 'start()'
# at ./test.pl line 78.
Use of uninitialized value $rc in addition (+) at /usr/lib/x86_64-linux-gnu/perl5/5.26/MIDI/ALSA.pm line 274.
ok 12 - queue_id is not negative and not SND_SEQ_QUEUE_DIRECT
Use of uninitialized value $fd in numeric gt (>) at ./test.pl line 87.
not ok 13 - fd()
# Failed test 'fd()'
# at ./test.pl line 87.
Use of uninitialized value in string eq at ./test.pl line 90.
not ok 14 - listclients()
# Failed test 'listclients()'
# at ./test.pl line 90.
Use of uninitialized value within %num2nports in numeric eq (==) at ./test.pl line 93.
not ok 15 - listnumports()
# Failed test 'listnumports()'
# at ./test.pl line 93.
Use of uninitialized value $rc in concatenation (.) or string at ./test.pl line 96.
ok 16 - skipping inputpending() returns
ok 17 - skipping input() test
ok 18 - skipping alsa2scoreevent() test
ok 19 - skipping input() test
ok 20 - skipping alsa2scoreevent() test
ok 21 - skipping input() test
ok 22 - skipping alsa2scoreevent() test
ok 23 - skipping input() test
ok 24 - skipping alsa2scoreevent() test
ok 25 - skipping listconnectedto() test
ok 26 - skipping listconnectedfrom() test
ok 27 - skipping patch_change event output
ok 28 - skipping control_change event output
ok 29 - skipping note_on event output
ok 30 - skipping note_off event output
ok 31 - skipping disconnectfrom()
ok 32 - skipping SND_SEQ_EVENT_PORT_UNSUBSCRIBED event
ok 33 - skipping disconnectto()
not ok 34 - connectto(2,'testpl pid=5892:1') connected to myself by name
# Failed test 'connectto(2,'testpl pid=5892:1') connected to myself by name'
# at ./test.pl line 287.
Use of uninitialized value $alsaevent[0] in numeric ne (!=) at ./test.pl line 294.
Use of uninitialized value in subtraction (-) at ./test.pl line 298.
not ok 35 - received an event from myself
# Failed test 'received an event from myself'
# at ./test.pl line 301.
# alsaevent=$VAR1 = [undef,undef,undef,1,'2.8'];
# correct =$VAR1 = [11,1,0,0,'2.8',[0,2],[0,1],[0,0,0,0,0,99]];
ok 36 - latency was -2799999 microsec
not ok 37 - disconnectfrom(1,0,2)
# Failed test 'disconnectfrom(1,0,2)'
# at ./test.pl line 309.
not ok 38 - status() reports running
# Failed test 'status() reports running'
# at ./test.pl line 314.
Use of uninitialized value $time in subtraction (-) at ./test.pl line 316.
Use of uninitialized value $time in concatenation (.) or string at ./test.pl line 316.
ok 39 - status() reports time = not 0.00388288497924805
Use of uninitialized value $time in subtraction (-) at ./test.pl line 324.
Use of uninitialized value $time in concatenation (.) or string at ./test.pl line 324.
not ok 40 - status() reports time = not 1.00435400009155
# Failed test 'status() reports time = not 1.00435400009155'
# at ./test.pl line 324.
not ok 41 - stop() returns success
# Failed test 'stop() returns success'
# at ./test.pl line 328.
Use of uninitialized value $qid in addition (+) at /usr/lib/x86_64-linux-gnu/perl5/5.26/MIDI/ALSA.pm line 305.
not ok 42 - noteonevent()
# Failed test 'noteonevent()'
# at ./test.pl line 332.
# alsaevent=$VAR1 = [6,1,0,'0','2.7',[0,0],[0,0],[15,72,100,0,0]];
# correct =$VAR1 = [6,1,0,0,'2.7',[0,0],[0,0],[15,72,100,0,0]];
Use of uninitialized value $qid in addition (+) at /usr/lib/x86_64-linux-gnu/perl5/5.26/MIDI/ALSA.pm line 316.
not ok 43 - noteoffevent()
# Failed test 'noteoffevent()'
# at ./test.pl line 339.
# alsaevent=$VAR1 = [7,1,0,'0','2.7',[0,0],[0,0],[15,72,100,100,0]];
# correct =$VAR1 = [7,1,0,0,'2.7',[0,0],[0,0],[15,72,100,100,0]];
ok 44 - noteevent()
ok 45 - pgmchangeevent() with time>=0
ok 46 - pgmchangeevent() with time undefined
ok 47 - pitchbendevent() with time>=0
ok 48 - pitchbendevent() with time undefined
ok 49 - chanpress() with time>=0
ok 50 - chanpress() with time undefined
ok 51 - scoreevent2alsa("note"...)
ok 52 - scoreevent2alsa("control_change"...)
ok 53 - scoreevent2alsa("patch_change"...)
ok 54 - scoreevent2alsa("pitch_wheel_change"...)
ok 55 - scoreevent2alsa("channel_after_touch"...)
ok 56 - scoreevent2alsa("sysex_f0"...)
ok 57 - scoreevent2alsa("sysex_f7"...)
# Looks like you failed 14 tests of 57.
autopkgtest [22:34:30]: test command1: -----------------------]
autopkgtest [22:34:30]: test command1: - - - - - - - - - - results - - - - - - - - - -
command1 FAIL non-zero exit status 14
So it looks like the situation is the same: We can't run the test
suite during build and/or autopkgtests because it needs kernel
modules and sound devices. Of course we can still decide to upload
the package, it just feels a bit - hm - unusual to me.
Cheers,
gregor
--
.''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Astrud Gilberto: All I've Got
Attachment:
signature.asc
Description: Digital Signature