On Sat, Oct 28, 2017 at 07:11:37PM +0200, Axel Beckert wrote:
> > I tried live patching strip-nd by chaging the
> > open(my $fh, '+<', $filename)
> > to
> > open(my $fh, '<', $filename)
> > and indeed I could get a build completely identical to the one done
> > without R³ and unpatched strip-nd (and the log confirms files are still
> > being processed by strip-nd.
>
> Did your example contain a PNG which needs a fixup?
Yes. I tried the same package you brought as an example,
systray-mdstat, which has png files that gets modified.
> Looking at
> https://anonscm.debian.org/git/reproducible/strip-nondeterminism.git/tree/t/fixtures/png
> it seems as if tEXt.png.in is a case where strip-nd should change
> something (while the other examples contain symlinks and hence I
> expect those being examples where nothing should be changed).
Yes.
> Maybe the test suite should do a variant with read-only files which
> need to be modified, too, to verify that this case works, too, and
> continues to work.
That's annoying to do, as it would be to be done through code since git
doesn't store the w bit.
> > So, I think that to handle this issue we should just drop that single
> > byte from strip-nd and consider it done.
>
> \O/
https://anonscm.debian.org/git/reproducible/strip-nondeterminism.git/commit/?id=e32fed6
Pending release, shall I cut one right away?
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature