[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#856616: unblock: libdevice-cdio-perl/0.3.0-6



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

unblock libdevice-cdio-perl/0.3.0-6

Please unblock package libdevice-cdio-perl, 0.3.0-6:

The upload only changes debian/rules to skip two tests which need
access to a physical CD-ROM drive. They were already skipped during
autopkgtest for that reason, and Santiago Vila now noted correctly in
#856334 that this is a problem during package build as well.

Full debdiff attached.

Thanks in advance,
gregor

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAli4nJFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qga7/w//Ty0YG3Y6vmwteiL3Vuo4GM7E4F7RDZz2cOrJevzhHTd65HKa9367cwNE
6XQzBfMEdj1RE9D9/E34Kh6HLRjyl7jJeMIEaZKkq3UhQ5PJVNKEPOtj/qBBB5+o
olB4Bz9rhMLod1dKBTi0gcD+dhwCoPXNv57wcWB+2RyFj2Quvjt7eiDFNi26HwNR
9VPQI+PtIJNL+D3wm2EkhFrMWZm7dAX9ZWw+BpTsjh5lMnKVZPWxqDY+jtWfvAeH
Xd3S2YqPTd8n3h3HEWFGiCztywKvPIsAyDYWtpv3VYt/qo6ZqwlZ6k6dNVILGYoo
SDRyK3pJhnBU3cZXUazuHCWFjw4BL1G/aXVWETuLQRS67xnzCkq3wnhwX2aHIBcQ
wbB4IY/s2XoK7CvKj4Vw1Nzm31P2uKBnnSZQyeeVcblrttSS+vftLT3vkZWng7rh
h1aHiHHich8c1cLwjnQ4m2F9RwCa1SYp/MNuG5Xv1v5JyIiLto0OUaT0zwRNMFoJ
o0EVnb/jGG8AmD882kXCvSFGb3L8J9BwEko6g2pq/mZVmCw160Bn6O0SVIwlWcPe
8AcVCDUjWSD+m4tCg1IwTeLfLvWY3OLJgtuKhJYHXdK/gwpHe3Q6kDECO2baKYg5
JxrAdOgUM/rCbmVW4xlUv1gqY14tcP8oVqK4+/Hs0+XU1wtv0FY=
=2ezB
-----END PGP SIGNATURE-----
diff -Nru libdevice-cdio-perl-0.3.0/debian/changelog libdevice-cdio-perl-0.3.0/debian/changelog
--- libdevice-cdio-perl-0.3.0/debian/changelog	2015-07-26 19:13:46.000000000 +0200
+++ libdevice-cdio-perl-0.3.0/debian/changelog	2017-03-02 23:20:33.000000000 +0100
@@ -1,3 +1,15 @@
+libdevice-cdio-perl (0.3.0-6) unstable; urgency=medium
+
+  * Skip tests which need a physical CD-ROM device during build.
+    The tests t/05.ops.t and t/11.dev.t were already skipped during
+    autopkgtest (by means of debian/tests/pkg-perl/skip-smoke) because it was
+    noted that they fail without a physical device, e.g. under QEMU. As the
+    same issue can arise during build, skip them as well in debian/rules
+    during build.
+    Thanks to Santiago Vila for the bug report. (Closes: #856334)
+
+ -- gregor herrmann <gregoa@debian.org>  Thu, 02 Mar 2017 23:20:33 +0100
+
 libdevice-cdio-perl (0.3.0-5) unstable; urgency=medium
 
   * Make dh_auto_configure verbose.
diff -Nru libdevice-cdio-perl-0.3.0/debian/rules libdevice-cdio-perl-0.3.0/debian/rules
--- libdevice-cdio-perl-0.3.0/debian/rules	2015-07-26 19:13:46.000000000 +0200
+++ libdevice-cdio-perl-0.3.0/debian/rules	2017-03-02 23:20:33.000000000 +0100
@@ -1,5 +1,9 @@
 #!/usr/bin/make -f
 
+# skip tests that need a physical CD-ROM drive
+SKIP_TESTS = $(shell cat debian/tests/pkg-perl/skip-smoke)
+TEST_FILES = $(sort $(filter-out $(SKIP_TESTS), $(wildcard t/*.t)))
+
 %:
 	dh $@ --buildsystem=perl_build
 
@@ -24,4 +28,4 @@
 	dh_auto_build
 
 override_dh_auto_test:
-	TZ=UTC dh_auto_test
+	TZ=UTC dh_auto_test -- --test_files="$(TEST_FILES)"

Reply to: