[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Question on workflow



Hello, perl team newbie workflow question: So i have a fix for #784545,
which works locally. How should I proceed? Just push the change into the
repo? Or should someone review it somehow, before i push it into the
repo? Or should the review happen in/via the repo?

Thanks for your help/suggestions/support.

Bye,

Simon


Am 2017-01-14 um 00:09 schrieb Simon Kainz:
> (IRC excert)
> 
>> gregoa| skainz: oh, I thought you had already joined. but maybe this
> was just wishful thinking :)
>> gregoa| skainz: I can only recommend to join and get free
> co-maintainers for your package
> 
> Hello list,
> 
> Just a short introduction:
> 
> I am DD since 2015 and attendes some DebConf's, even before becoming DD,
> so some of you might know me already.
> 
> I work as a sysadmin in academic context, responsibe for HPC stuff as
> well as "the usual Linux stuff".
> 
> 
> I am quite fluent in Perl and use quite a lot of perl for work as well
> as for one of my Debian packages (duck). My other Debian-related
> interest is QA. My reasons to join pkg-perl are
> 
> * i am always amazed to find out that all perl related stuff i need is
> already packaged
> 
> * I am currently trying to package libfsm-simple-perl and don't want to
> just drop even more work on all of you!
> 
> And yes, gregoa's announcement about free co-maintainership also helped :-)
> 
> So, be prepared for some perl-packaging-newbie questions.
> 
> Bye,
> 
> Simon
> 
> 

-- 
ᘓ Debian Developer
  4096R/ED98D2D344641A6859A0864F1CB4F0F78DECAFE9
  Get my key:  finger skainz/key@db.debian.org
               http://blog.familiekainz.at/static/gpg/8DECAFE9.asc
diff --git a/debian/changelog b/debian/changelog
index cdc2516..cb77fc2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -18,7 +18,11 @@ libfile-mimeinfo-perl (0.28-1) UNRELEASED; urgency=medium
   * Bump debhelper compatibility level to 9.
   * Add a patch to fix a spelling mistake in the documentation.
 
- -- gregor herrmann <gregoa@debian.org>  Mon, 28 Nov 2016 21:48:38 +0100
+  [ Simon Kainz ]
+  * fix for always reporting text/plain when reading from stdin,
+    (Closes: #784545)
+    
+ -- Simon Kainz <skainz@debian.org>  Thu, 19 Jan 2017 13:03:21 +0100
 
 libfile-mimeinfo-perl (0.27-1) unstable; urgency=medium
 
diff --git a/debian/patches/fix_read_from_stdin.patch b/debian/patches/fix_read_from_stdin.patch
new file mode 100644
index 0000000..039c1b3
--- /dev/null
+++ b/debian/patches/fix_read_from_stdin.patch
@@ -0,0 +1,15 @@
+Description: fix reading from stdin  always reporting text/plain mime-type
+Origin: vendor
+Bug-Debian: https://bugs.debian.org/784545
+Last-Update: 2017-01-19
+
+--- libfile-mimeinfo-perl-0.28.orig/mimetype
++++ libfile-mimeinfo-perl-0.28/mimetype
+@@ -166,6 +166,7 @@ if ($args{stdin}) {
+ # --stdin
+ if ($args{stdin}) {
+ 	my $data;
++	&File::MimeInfo::Magic::rehash();
+ 	read(STDIN, $data, $File::MimeInfo::Magic::max_buffer);
+ 	my $scalar = new IO::Scalar \$data;
+ 	print $format->('STDIN', mimetype($scalar)), "\n";
diff --git a/debian/patches/series b/debian/patches/series
index 5299247..9fc9018 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 spelling.patch
+fix_read_from_stdin.patch

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: