[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#839905: Bug#840293: pkg-kde-tools: pkgkde-symbolshelper broken by perl 5.24

On Thu, 13 Oct 2016 17:13:09 -0300, Lisandro Damián Nicanor Pérez Meyer wrote:

> Steps to reproduce:
> apt-get source -t experimental qtdeclarative-opensource-src
> cd qtdeclarative-opensource-src-5.7.0/
> getbuildlog qtdeclarative-opensource-src last
> pkgkde-symbolshelper batchpatch -v 5.7.0 *.log

That makes it indeed easier to reproduce :)

So, my findings:
- the error "reopen stdout: Bad file descriptor" happens in
  /usr/share/perl5/Debian/PkgKde/SymbolsHelper/Patching.pm line 246:
  wait_child($pid, nocheck => 1);
- that's when the formerly assembled $pid gets executed
- looking at $pid above, I notice that both to_handle and
  error_to_handle are set to $outfile (a temp file created before)
- just out of curiosity, I commented out the error_to_handle line
  (241), and now `pkgkde-symbolshelper batchpatch -v 5.7.0 *.log'
- running `pkgkde-symbolshelper batchpatch -v 5.7.0 *.log' again
  fails with failed hunk errors from patch, which also doesn't look
  so bad

Not sure where this leaves us, especially since I neither know
Dpkg::IPC nor understand the apply() sub in

Maybe guillem and/or modax as the respective authors can help here.  

(And I also don't know where exactly the problem / changed behaviour
with perl 5.24 lies. Since the spawn/wait_pid functions are from
Dpkg::IPC, I guess looking into Dpkg::IPC might be interesting.)


 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bob Dylan: Tweedle Dee & Tweedle Dum

Attachment: signature.asc
Description: Digital Signature

Reply to: