[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: libnet-server-coro-perl_1.3-1_amd64.changes ACCEPTED into unstable



Hi Angel, Xavier, Dmitry, hi Release Team

On Fri, Nov 16, 2012 at 12:17:27PM +0000, Debian FTP Masters wrote:
>
> Accepted:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Format: 1.8
> Date: Fri, 16 Nov 2012 05:57:33 +0100
> Source: libnet-server-coro-perl
> Binary: libnet-server-coro-perl
> Architecture: source all
> Version: 1.3-1
> Distribution: unstable
> Urgency: low
> Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
> Changed-By: Xavier Guimard <x.guimard@free.fr>
> Description:
>  libnet-server-coro-perl - co-operative multithreaded server using Coro
> Changes:
>  libnet-server-coro-perl (1.3-1) unstable; urgency=low
>  .
>    * Imported Upstream version 1.3
>    * Update copyright to format 1.0
>    * Bump Standards-Version to 3.9.4
>    * Update debian/rules to modern format
>    * Add dependency version to libnet-server-perl
>    * Remove patches now included in upstream
>    * Update debian/watch
[...]

This upload is quite unfortunate as shortly discussed today on IRC
#debian-release.

libnet-server-coro-perl had a unblock already granted by Adam to fix a
RC bug in wheezy. The package was ready to migrate to wheezy in 5
days. The new upload now has some changes who do not comply with the
freeze policy[1].

 [1]: http://release.debian.org/wheezy/freeze_policy.html

I think there are now some possible options, whereas I personally
prefer the first one, the removal from wheezy:

 - Remove the package from wheezy. It still has some (packaging)
   glitches and issues and has a really low popcon anyway. E.g. only if
   Recommends are installed it works, if libev-perl is missing then
   Net::Server::Coro fails (so another serious bug):

   perl -MNet::Server::Coro 
   Can't locate EV.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /usr/share/perl5/Net/Server/Coro.pm line 7.
   BEGIN failed--compilation aborted at /usr/share/perl5/Net/Server/Coro.pm line 7.
   Compilation failed in require.
   BEGIN failed--compilation aborted.

   This is the case for the 1.2-1 (this was missed previously and only
   noticed now when looking at the package today).

 - Revert the changes done in unstable, and upload a 1.2-3 based (either
   bumping epoch or adding a really1.2-3 ...)?

 - Upload the package 1.2-3 as 1.2-3+deb7u1 to t-p-u. In both cases
   above there is dependency missing to libev-perl which should be
   added (and libanyevent-perl removed -- it doesn't look to be used in
   the code).

 - Nevertheless accept the 1.3-1 to migrate to wheezy, but with the
   following debdiff stat from 1.2-3 to 1.3-1:

    Changes                           |    5 ++++-
    META.yml                          |   13 +++++++------
    Makefile.PL                       |    4 ++--
    SIGNATURE                         |   32 ++++++++++++++++----------------
    debian/changelog                  |   12 ++++++++++++
    debian/compat                     |    2 +-
    debian/control                    |   36 +++++++++++++++++++-----------------
    debian/copyright                  |   54 ++++++++++++++++++++++++++----------------------------
    debian/patches/fix_perldoc_errors |   20 --------------------
    debian/patches/fix_undef_warning  |   11 -----------
    debian/patches/series             |    2 --
    debian/rules                      |   26 ++------------------------
    debian/watch                      |    2 +-
    inc/Module/Install.pm             |    6 +++---
    inc/Module/Install/Base.pm        |    2 +-
    inc/Module/Install/Can.pm         |   85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
    inc/Module/Install/Fetch.pm       |    2 +-
    inc/Module/Install/Makefile.pm    |   27 +++++++++++++++------------
    inc/Module/Install/Metadata.pm    |   22 ++++++++++++++--------
    inc/Module/Install/Win32.pm       |    2 +-
    inc/Module/Install/WriteAll.pm    |    2 +-
    lib/Net/Server/Coro.pm            |   71 ++++++++++++++++++++++++++++++++++++++++++++---------------------------
    lib/Net/Server/Proto/Coro.pm      |    1 +
    23 files changed, 250 insertions(+), 189 deletions(-)

   I agree that most part is in inc/* but I don't think this is
   'acceptable' for an unblock.

Summary: With the issues open in 1.2-3 it looks best to simple remove
libnet-server-coro-perl from wheezy ... (but one needs to also remove
its reverse (build-)dependency libcorona-perl; but reading #680774
this should anyway not be released for now in wheezy).

Note: I have only a Debian Perl Group member view on it and not using
the coro related modules.

Regards,
Salvatore

Attachment: signature.asc
Description: Digital signature


Reply to: