[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#690281: unblock: file-mmagic/1.29-1



Hi,

Adam D. Barratt wrote (13 Oct 2012 15:06:42 GMT) :
>> Old file-mmagic uses deprecated perl syntax, so I want to unblock it.
>> The follwing is diff (really small changes):
>> http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=286&r2=279

(That's the diff from "somewhere in between 1.27 and 1.28" to 1.29...)

> The upstream diff for that particular fix might be really small
> and targeted.

It is. The revision that fixes this specific bug is 281:
http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=279&r2=281
It is really tiny and looks correct to me.
It might be a fine candidate for 1.27-2 and tpu
if someone cares enough.

The upstream ticket corresponding to this issue is
https://rt.cpan.org/Public/Bug/Display.html?id=74252

It seems to me the actual issue that patch fixes only may impact the
test suite of other modules that check for unexpected warnings. AFAIK,
Lucas' archive rebuilds did not detect any FTBFS caused by this bug in
Debian, so I would say it's low priority. Fellow debian-perl members,
did you see any?

Another bugfix that might be useful to include in Wheezy is r279
(memory leak fix):
http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=278&r2=279

Cheers,
--
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc


Reply to: