On Fri, 16 Dec 2011 10:39:35 +0800, James Bromberger wrote: > I think I've got it sorted. I've followed the documentation and set up > my repo in vasks, pushed my local git repo there, built package, and > uploaded to incoming (closing ITP #652203). I'd appreciate anyone wants > to review the repo and let me know what I've done wrong this time. :) Nothing tragic, just a few nitpicks concerning the package itself: - I'd remove d/libchi-driver-memcached-perl.docs, the README is just a text version of the POD - d/copyright: the years of upstream copyright are missing (probably 2007-2011) - d/control: * Vcs-* headers are missing * libchi-perl doesn't need a version (nothing older in the archive) * short description should be a noun phrase * (totally cosmetic): Build-Depends-Indep could be wrapped Looking at the git repo: * there's no upstream and no pristine-tar branch * there are no tags If you haven't pushed them please do so, otherwise you can use the git-missing-upstream script (in our scripts repo) to recreate them. Oh, and after downloading the tarball with uscan, the package doesn't build: dpkg-source: info: using source format `3.0 (quilt)' dpkg-source: info: building libchi-driver-memcached-perl using existing ./libchi-driver-memcached-perl_0.14.orig.tar.gz dpkg-source: info: local changes detected, the modified files are: libchi-driver-memcached-perl-0.14/dist.ini dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libchi-driver-memcached-perl_0.14-1.diff.C8V67v dpkg-source: info: you can integrate the local changes with dpkg-source --commit dpkg-buildpackage: error: dpkg-source -b libchi-driver-memcached-perl-0.14 gave error exit status 2 When trying to add an upstream branch from the CPAN tarball with the aforementioned script, I get a merge conflict and see: #v+ diff --cc dist.ini index 2511a26,b206d8a..0000000 --- a/dist.ini +++ b/dist.ini @@@ -38,8 -38,6 +38,11 @@@ CHI = 0.3 [Prereqs / TestRequires] Test::Class = 0 Test::More = 0 ++<<<<<<< HEAD +Test::Deep = 0 +Test::Exception = 0 ++======= ++>>>>>>> upstream ; These need to be at the bottom [InstallGuide] #v- If I'm reading this correctly you've added two lines to dist.ini; I think that's not needed (we can declare the build dependencies anyway) but if you want to do this you need to make a proper patch to avoid that dpkg-source bails out. (But maybe I'm reading this wrong :)) After resolving the conflict (by using the upstream version, i.e. removing the 2 lines) the package builds. During the build I see a few skipped tests: t/CHIDriverTests-Fast.t .......... skipped: one of required modules not installed: Cache::Memcached::Fast t/CHIDriverTests-libmemcached.t .. skipped: one of required modules not installed: Cache::Memcached::libmemcached t/CHIDriverTests-Memcached.t ..... skipped: one of required modules not installed: Cache::Memcached t/pod.t .......................... skipped: Test::Pod 1.22 required for testing POD I assume (but haven't checked) that adding a few more build dependencies would activate them. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key ID: 0x8649AA06 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe `- NP: Leonard Cohen: Winter Lady
Attachment:
signature.asc
Description: Digital signature