[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r70091 - /trunk/libaudio-mpd-perl/debian/changelog



On Mon, 28 Feb 2011 19:49:12 +0100, Alessandro Ghedini wrote:

> On Mon, Feb 28, 2011 at 05:54:34PM -0000, gregoa@users.alioth.debian.org wrote:
> > +  TODO:
> > +  - d/copyright: bin/mpd-rate has "2010"
> There are 3 notices about bin/mpd-rate copyright (one in the beginning
> comment and two in the POD at the end of the file). Two of them have "2007"
> the other one has "2010". Can we assume the "2010" one is the correct one?

Probably. I think we can also summarise the copyright years for all
files (currently there's "Files: *", "Files: bin/mpd-dynamic" and then
I stumbled over this one) a bit ...
 
> > +  - the configure/test output looks a bit weird (cowbuilder chroot):
> > +    # Test::Corpus::Audio::MPD: could not start fake mpd:
> > +    # ** (mpd:2709): CRITICAL **: option parsing failed: Unknown option --create-db
> > +    #
> > +    #
> > +    # Compilation failed in require at (eval 341) line 1.
> > +
> > +    # Test::Corpus::Audio::MPD                      => died during require. (want 1.092920)
> Seems a bug in Test::Corpus::Audio::MPD. I've reported it upstream [0], 

Thanks!

> should I also patch libtest-corpus-audio-mpd-perl? 

Depends on how urgent you consider it. (And if this bug causes other
problems than keeping libaudio-mpd-perl from being updated).

> In addition, probably 
> the dependency on mpd should be added to libtest-corpus-audio-mpd-perl 
> rather than to libaudio-mpd-perl.

Yup, sounds reasonable.


Thanks for all your work in this "upgrade sprint"!


Cheers,
gregor
 
 
-- 
 .''`.   http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    NP: Bob Dylan: Can't Wait

Attachment: signature.asc
Description: Digital signature


Reply to: