[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#608413: Possible patch for libio-socket-inet6-perl?



Hi

On Thu, Jan 06, 2011 at 03:00:20PM +0100, gregor herrmann wrote:
> On Thu, 06 Jan 2011 07:50:42 +0100, Salvatore Bonaccorso wrote:
> 
> > > I said on IRC the debian/rules change was wrong, and for the rest I'd
> > > like an ack/review from a perl person, which I'm not.
> 
> I don't know enough about sockets and ipv6 to make real judgement,
> but:
>  
> > Julien, on the other side I got confirmation from Julien Blache in
> > #608413, that the backported change from the diff 2.54 to 2.55 would
> > work again with the cricket setup.
> 
> That's fine, but this change does not contain the fix for 
> https://rt.cpan.org/Ticket/Display.html?id=55901 (inet_pton /
> inet_ntop import warnings) which I remember myself and which was
> very annoying at least, so I'd rather opt for moving 2.65 to
> testing (giving some code review from another more knowledgable
> person).

I have prepared the NMU for 2.65 with the change dh_clean -> dh_prep
instead of using dh_clean -k. But we still need a review regarding
ipv6 changes from a knowledgable person ;-)

Bests
Salvatore
diff -u libio-socket-inet6-perl-2.65/debian/changelog libio-socket-inet6-perl-2.65/debian/changelog
--- libio-socket-inet6-perl-2.65/debian/changelog
+++ libio-socket-inet6-perl-2.65/debian/changelog
@@ -1,3 +1,11 @@
+libio-socket-inet6-perl (2.65-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Revert changes to the dh_clean call in the install target: use dh_prep
+    instead of dh_clean -k. 
+
+ -- Salvatore Bonaccorso <carnil@debian.org>  Sun, 16 Jan 2011 09:33:09 +0100
+
 libio-socket-inet6-perl (2.65-1) unstable; urgency=low
 
   * New upstream release (closes: Bug#575531)
diff -u libio-socket-inet6-perl-2.65/debian/rules libio-socket-inet6-perl-2.65/debian/rules
--- libio-socket-inet6-perl-2.65/debian/rules
+++ libio-socket-inet6-perl-2.65/debian/rules
@@ -39,7 +39,7 @@
 install: 
 	dh_testdir
 	dh_testroot
-	dh_clean
+	dh_prep	
 	dh_installdirs
 
 	$(MAKE) install PREFIX=$(TMP)/usr

Attachment: signature.asc
Description: Digital signature


Reply to: