[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

SOAP::Lite: enquiry about freeze exception



The latest release of libsoap-lite-perl fixes #602056. This was marked grave because it "renders package unusable". I am not sure if this warrants a freeze exception. I would appreciate an opinion and appropriate action. Debdiff attached.
diff -Nru libsoap-lite-perl-0.712/debian/changelog libsoap-lite-perl-0.712/debian/changelog
--- libsoap-lite-perl-0.712/debian/changelog	2010-06-13 13:35:46.000000000 +0100
+++ libsoap-lite-perl-0.712/debian/changelog	2010-11-03 11:15:36.000000000 +0000
@@ -1,3 +1,13 @@
+libsoap-lite-perl (0.712-2) UNRELEASED; urgency=low
+
+  [ gregor herrmann ]
+  * Remove Conflicts: libsoap-perl.
+
+  [ Nicholas Bamber ]
+  * Applying patch to fix hash reference crash (Closes: #602056)
+
+ -- gregor herrmann <gregoa@debian.org>  Sat, 31 Jul 2010 15:32:20 -0400
+
 libsoap-lite-perl (0.712-1) unstable; urgency=low
 
   [ Franck Joncourt ]
diff -Nru libsoap-lite-perl-0.712/debian/control libsoap-lite-perl-0.712/debian/control
--- libsoap-lite-perl-0.712/debian/control	2010-06-06 18:46:58.000000000 +0100
+++ libsoap-lite-perl-0.712/debian/control	2010-11-03 08:20:20.000000000 +0000
@@ -27,7 +27,6 @@
  perl (>= 5.10.0) | libversion-perl, libtask-weaken-perl, perl (>= 5.9.3),
  libclass-inspector-perl
 Suggests: libapache2-mod-perl2, libnet-jabber-perl, libmime-lite-perl
-Conflicts: libsoap-perl
 Description: Perl implementation of a SOAP client and server
  SOAP::Lite is a collection of Perl modules that provide a simple and
  lightweight interface to the Simple Object Access Protocol (SOAP) both on
diff -Nru libsoap-lite-perl-0.712/debian/patches/hashref_crash.patch libsoap-lite-perl-0.712/debian/patches/hashref_crash.patch
--- libsoap-lite-perl-0.712/debian/patches/hashref_crash.patch	1970-01-01 01:00:00.000000000 +0100
+++ libsoap-lite-perl-0.712/debian/patches/hashref_crash.patch	2010-11-03 11:30:12.000000000 +0000
@@ -0,0 +1,20 @@
+--- a/lib/SOAP/Lite.pm
++++ b/lib/SOAP/Lite.pm
+@@ -3747,13 +3747,13 @@
+                 # fillup parameters
+                 UNIVERSAL::isa($_[$param] => 'SOAP::Data')
+                     ? $_[$param]->SOAP::Data::value($value)
+-                    : UNIVERSAL::isa($_[$param] => 'ARRAY')
++                    : (ref($_[$param] eq 'ARRAY'))
+                         ? (@{$_[$param]} = @$value)
+-                        : UNIVERSAL::isa($_[$param] => 'HASH')
++                        : (ref($_[$param]) eq 'HASH')
+                             ? (%{$_[$param]} = %$value)
+-                            : UNIVERSAL::isa($_[$param] => 'SCALAR')
++                            : (ref($_[$param]) eq 'SCALAR')
+                                 ? (${$_[$param]} = $$value)
+-                                : ($_[$param] = $value)
++                                : ($_[$param] = $value);
+             }
+         }
+     }
diff -Nru libsoap-lite-perl-0.712/debian/patches/series libsoap-lite-perl-0.712/debian/patches/series
--- libsoap-lite-perl-0.712/debian/patches/series	2010-06-13 13:33:07.000000000 +0100
+++ libsoap-lite-perl-0.712/debian/patches/series	2010-11-07 09:21:01.000000000 +0000
@@ -1 +1,2 @@
 spelling.patch
+hashref_crash.patch

Reply to: