[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r34588 - /trunk/libhtml-template-compiled-perl/debian/changelog



On Fri, May 01, 2009 at 08:20:14PM -0000, gregoa@users.alioth.debian.org wrote:
> Author: gregoa
> Date: Fri May  1 20:19:58 2009
> New Revision: 34588
> 
> URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=34588
> Log:
> back to UNRELEASED, TODO added to changelog

Once again, thanks for the review, and see below...

> --- trunk/libhtml-template-compiled-perl/debian/changelog (original)
> +++ trunk/libhtml-template-compiled-perl/debian/changelog Fri May  1 20:19:58 2009
> @@ -1,4 +1,12 @@
> -libhtml-template-compiled-perl (0.93-1) unstable; urgency=low
> +libhtml-template-compiled-perl (0.93-1) UNRELEASED; urgency=low
> +
> +  TODO:
> +  * debian/README.source missing (document quilt usage, required since policy 3.8.1)

Argh.  I really can't believe I missed this.  Follow the debian-policy
list closely for more than an year, bring up almost a dozen packages
to Policy 3.8.1 in the past couple of months, and then... just forgot.

Done in rev. 34974.

> +  * debian/rules: just curious: why the "$(MAKE) -f debian/rules unpatch"
> +    instead of the usual "clean: unpatch"?

Well, it's just a habit from my other packages.  It is needed when
I'm also patching the build system - if a Makefile is modified, then
"make clean" *after* "quilt pop -a" might not clean everything and
might even fail in other package-dependent ways.  I'm just used to
doing it the same way in all my packages; however, I realize that
it's a bit more important for the team that it's done the same way
in all the team's packages :)  I'll change it back in a minute.

> +  * debian/control: cosmetics:
> +    - probably s/System/system/ in short description
> +    - probably s/different/&ly/ in long description

Yep, the descriptions were a bit off indeed.  Fixed... I think :)

Thanks again!

G'luck,
Peter

-- 
Peter Pentchev	roam@ringlet.net    roam@space.bg    roam@FreeBSD.org
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
I've heard that this sentence is a rumor.

Attachment: pgpdn_zilxwg7.pgp
Description: PGP signature


Reply to: