[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Re: Sys::SigAction



-=| Jeffrey Ratcliffe, Tue, Feb 03, 2009 at 09:23:07PM +0100 |=-
> 2009/1/20  <jeffrey.ratcliffe@gmail.com>:
> > A polite email has indeed done the trick. He says he will upload a new
> > version with the licence and other issues fixed in a couple of weeks.
> 
> True to his word, he has uploaded a new version with the licence
> restriction removed, so I have just svn-injected
> libsys-sigaction-perl.

Great!

> I'd be grateful if someone would cast an eye over it.

I did :) Here's some nitpicking:

debian/copyright
''''''''''''''''
lintian complains that (C) alone means nothing. I think it means the 
packaging copyright.

also, the pointers to full text of GPL/Artistic are missing.

debian/control
''''''''''''''
does "Consistent Signal Handling" really needs to be with capital 
first letters? I see upstream uses that too, but what should it mean?

s/This module/Sys::SigAction/ ?

there is an extra space before the short description

Maintainer: should be set to the group and Uploaders: -- to you

misc
''''
perhaps including the dbd-oracle-timeout.pod article somewhere as 
a doc would be useful?

debian/rules uses dh7 features, debian/control b-depends on debhelper 
(>= 7), but debian/compat contains "5"


That's all remarks I have for tonight :)


> P.S. Is there any problem preparing packages depending on something in
> the NEW queue?

No. Building them in chroot is a bit tricky, but doable.


Tahank you for your work!

-- 
dam            JabberID: dam@jabber.minus273.org

Attachment: signature.asc
Description: Digital signature


Reply to: