Bug#556934: libcurses-ui-perl: flushkeys() called at inappropriate time
Package: libcurses-ui-perl
Version: 0.9605-1.6
Severity: important
Tags: patch
In a similar vein to #556846, there is an extraneous function call that breaks
input when keys are buffered. The call to flushkeys() from feedkey() simply
throws keys away for no discernable reason.
Again, I'm raising this bug as I'd like to implement the patch in Debian, but
would welcome input from other members of the Debian Perl team. I will raise
the issue upstream as well.
Antony
-- System Information:
Debian Release: 5.0.3
APT prefers stable
APT policy: (500, 'stable')
Architecture: i386 (i686)
Kernel: Linux 2.6.30-bpo.2-686 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages libcurses-ui-perl depends on:
ii libcurses-perl 1.23-1+b1 Curses interface for Perl
ii libterm-readkey-perl 2.30-4 A perl module for simple terminal
ii perl 5.10.0-19lenny2 Larry Wall's Practical Extraction
libcurses-ui-perl recommends no packages.
libcurses-ui-perl suggests no packages.
-- no debconf information
#! /bin/sh /usr/share/dpatch/dpatch-run
## 04_flushkeys.dpatch by <antony@labrie.wayforth.com>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: No description.
@DPATCH@
diff -urNad libcurses-ui-perl-0.9605~/lib/Curses/UI.pm libcurses-ui-perl-0.9605/lib/Curses/UI.pm
--- libcurses-ui-perl-0.9605~/lib/Curses/UI.pm 2009-11-18 12:14:40.000000000 +0000
+++ libcurses-ui-perl-0.9605/lib/Curses/UI.pm 2009-11-18 12:15:51.000000000 +0000
@@ -504,7 +504,9 @@
{
my $self = shift;
my $key = shift;
- $self->flushkeys();
+ # Removed by Antony Gelberg for Debian - again this causes things to get
+ # out of sync.
+ #$self->flushkeys();
$self->{-feedkey} = $key;
return $self;
}
Reply to: