[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#524127: [uscan] 'x509_user' not valid URI scheme at /usr/bin/uscan line 389



That is strange behaviour indeed, and I'm really not sure how such a
bug would have made it into LWP, especially since it's *much* much
easier JUST to test for HTTP_PROXY and FTP_PROXY or some similar
scheme...

On Fri, Apr 17, 2009 at 12:58 PM, Damyan Ivanov <dmn@debian.org> wrote:
> clone 524127 -1
> reassign -1 libwww-perl
> block 524127 -1
> notfound -1 devscripts/2.10.48
> found -1 5.821
> retitle -1 LWP::UserAgent interprets evety *_proxy environment variable when env_proxy is given
> thanks
>
>
> -=| Steffen Moeller, Thu, Apr 16, 2009 at 02:26:27PM +0200 |=-
>> Hi Adam,
>>
>> Adam D. Barratt wrote:
>> > On Thu, 2009-04-16 at 02:45 +0200, Steffen Moeller wrote:
>> >> the issue seems to be invariant of the watch file used. It still occurs.
>> > [...]
>> >> $ set | grep -i proxy
>> >> X509_USER_PROXY=/home/moeller/myproxy
>> >
>> > Aha! This seems to be due to a change made upstream in libwww-perl in
>> > version 5.821:
>> >
>> >       croak on bad proxy args [RT#39919]
>> >
>> > This is easily confirmable by checking whether the following also fails
>> > for you:
>> >
>> >         #! /usr/bin/perl
>> >         use LWP::UserAgent;
>> >         my $ua = LWP::UserAgent->new(env_proxy => 1);
>> >
>> > env_proxy is documented as reading environment variables of the form
>> > *_proxy.
>>
>> Your hunch did not fool you.
>>
>> $ perl a.pl
>> 'x509_user' is not a valid URI scheme at a.pl line 3
>>
>> It (including uscan) works with env_proxy => 0, but this obviously is not what you want.
>>
>> > LWP maintainers - any thoughts? Should clients (e.g. uscan) be
>> > attempting to sanitise the proxy variables in the environment to only
>> > include those they specifically care about before using env_proxy? (or
>> > wrapping the call in an eval() and ignoring the specific error)
>> >
>> > That's obviously doable, but would need doing in every client
>> > individually, which seems somewhat overkill.
>>
>> Somehow it seems strange to reserve all _PROXY variably for oneself.
>
> Full ack!
>
> What I'd expect would be to try HTTP_PROXY for http:// URL, and
> FTP_PROXY for ftp:// URLs.
>
> Croaking on "illegal" *_PROXY environment variables seems silly, as
> the user may have these set for reasons completely unrelated to
> LWP::UA.
>
> Bug cloned/reassigned. Thanks for bringing it up.
>
> --
> dam            JabberID: dam@jabber.minus273.org
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAknotUcACgkQHqjlqpcl9jtOMwCggTGSBF5jlUquKAekAdLQ4YuD
> oDIAnR983b9jPZAI62xQpqmHJJmJf6hz
> =WYTO
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> pkg-perl-maintainers mailing list
> pkg-perl-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-perl-maintainers
>


Reply to: