Hello Release Team. I'm writing on behalf of pkg-perl asking to unblock libpoe-component-client-dns-perl the current lenny's version is 1:1.00-1 the version from unstable is 1:1.01-2 the changes from upstream new version are minimal, is just a version's raise and an include from a debian patch [0] in 1:1.01-2 version will fix #506915 [1] The -2 changes just include the pattch to use Net::DNS instead of hard-code IP's address [1] There is a full diff from 1:1.00-1 to 1:1.01-2 attached. [0] http://rt.cpan.org/Public/Bug/Display.html?id=33677 this patch was included at 1:1.00-1 [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=506915 Cheers -- Rene Mauricio Mayorga | jabber: rmayorga@jabber.org http://rmayorga.org | -------------------------------------------------- 08B6 58AB A691 DD56 C30B 8D37 8040 19FA A209 C305
diff -pruN libpoe-component-client-dns-perl-1.00/CHANGES libpoe-component-client-dns-perl-1.01/CHANGES
--- libpoe-component-client-dns-perl-1.00/CHANGES 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/CHANGES 2008-11-30 00:50:00.000000000 -0600
@@ -1,57 +1,19 @@
-======================================
-9999-99-99 99:99:99.999999Z (untagged)
-======================================
+=================================
+2008-10-29T16:19:41.680362Z v1_01
+=================================
- 2007-01-06 18:12:47 (r64) by rcaputo; DNS.pm M
+ 2008-10-29 16:18:54 (r68) by rcaputo; DNS.pm M
- By the power of PAUSEskull, this is a fine morning! Release 1.00!
+ New version.
- 2007-01-06 18:11:52 (r63) by rcaputo; DNS.pm M
+ 2008-10-15 03:18:31 (r67) by rcaputo; t/06_hosts.t M
- Expose the underlying Net::DNS::Resolver with a get_resolver()
- accessor. Thanks to Chris Williams for kinda suggesting it. :)
+ Accommodate DNS change for poe.perl.org in the tests.
- 2006-11-06 19:23:35 (r62) by rcaputo; Makefile.PL M
+ 2008-03-24 17:33:22 (r66) by rcaputo; t/06_hosts.t M
- Set a LICENSE. Cheap kwalitee points!
-
- 2006-10-17 16:35:24 (r61) by rcaputo; t/06_hosts.t M
-
- Don't try to call a method on a failed request. Resolves rt.cpan.org
- 21190 by Alexandr Ciornii.
-
- 2006-10-17 15:05:34 (r60) by rcaputo; Makefile.PL M
-
- Some rt.cpan.org tickets refer to issues in Net::DNS. Require the
- latest version of that dependency in the hopes that some things are
- fixed. Too bad I don't have test cases for those issues... there's no
- way for me to tell if anything's fixed by this simple change.
-
-=========================
-2006-05-21 20:45:46 v0_99
-=========================
-
- 2006-05-21 20:45:11 (r58) by rcaputo; DNS.pm M
-
- Bump up the version.
-
- 2006-05-21 20:44:39 (r57) by rcaputo; DNS.pm M
-
- Fix shutdown(). It was not performing nearly enough cleanup.
-
- Replace some post() calls with call() to avoid race conditions. In
- general, method interfaces should use call() rather than post() so
- that they affect internal structures synchronously.
-
- 2006-05-21 20:43:08 (r56) by rcaputo
- t/02_tag_args.t M; t/03_api_3.t M; t/05_api_4.t M; t/06_hosts.t M
-
- Turn on ASSERT_DEFAULT for some of the tests. Add _stop handlers so
- they don't fail with all POE asserts on.
-
- 2006-03-24 03:58:51 (r55) by rcaputo; DNS.pm M
-
- Belatedly bump up the version.
+ Apply Martin Ferrari's patch to skip network tests if there's no
+ detectable network. Resolves rt.cpan.org ticket 33677.
==============
End of Excerpt
diff -pruN libpoe-component-client-dns-perl-1.00/debian/changelog libpoe-component-client-dns-perl-1.01/debian/changelog
--- libpoe-component-client-dns-perl-1.00/debian/changelog 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/changelog 2008-11-30 00:50:00.000000000 -0600
@@ -1,3 +1,39 @@
+libpoe-component-client-dns-perl (1:1.01-2) unstable; urgency=low
+
+ [ gregor herrmann ]
+ * debian/control: Changed: Switched Vcs-Browser field to ViewSVN
+ (source stanza).
+
+ [ Rene Mayorga ]
+ * Add debian/patches/use_netdns_instead_of_harcode_ips.patch
+ + this use Net::DNS to resolve poe.perl.org IP address instead of
+ using a hardcode address at tests. Closes: #506915
+ * add myself to uploaders.
+
+ -- Rene Mayorga <rmayorga@debian.org.sv> Fri, 28 Nov 2008 17:05:53 -0600
+
+libpoe-component-client-dns-perl (1:1.01-1) unstable; urgency=low
+
+ [ Martín Ferrari ]
+ * Updating my email address
+
+ [ Jose Luis Rivas ]
+ * New upstream release
+ * Switched to debhelper v7, updated debian/rules, debian/compat and upgraded
+ debhelper dependency to >= 7 on debian/control.
+ * Patch is applied from upstream, no longer needed.
+ * Added me as Uploader.
+ * debian/control: Bumped to Standards-Version 3.8.0 (no changes needed).
+ * Refreshed debian/copyright.
+
+ [ gregor herrmann ]
+ * debian/copyright: use stand-alone License: stanzas instead of free text.
+ * Add patch fix_pod.patch.
+ * Add debian/README.source to document quilt usage, as required by
+ Debian Policy since 3.8.0.
+
+ -- Jose Luis Rivas <ghostbar38@gmail.com> Sun, 02 Nov 2008 02:35:10 -0430
+
libpoe-component-client-dns-perl (1:1.00-1) unstable; urgency=low
[ gregor herrmann ]
diff -pruN libpoe-component-client-dns-perl-1.00/debian/compat libpoe-component-client-dns-perl-1.01/debian/compat
--- libpoe-component-client-dns-perl-1.00/debian/compat 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/compat 2008-11-30 00:50:00.000000000 -0600
@@ -1 +1 @@
-5
+7
diff -pruN libpoe-component-client-dns-perl-1.00/debian/control libpoe-component-client-dns-perl-1.01/debian/control
--- libpoe-component-client-dns-perl-1.00/debian/control 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/control 2008-11-30 00:50:00.000000000 -0600
@@ -1,15 +1,16 @@
Source: libpoe-component-client-dns-perl
Section: perl
Priority: extra
-Build-Depends: debhelper (>= 5), quilt
+Build-Depends: debhelper (>= 7), quilt (>= 0.40)
Build-Depends-Indep: perl, libpoe-perl (>= 2:0.31), libnet-dns-perl (>= 0.59),
netbase
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
-Uploaders: Martín Ferrari <martin.ferrari@gmail.com>
-Standards-Version: 3.7.3
+Uploaders: Martín Ferrari <tincho@debian.org>,
+ Jose Luis Rivas <ghostbar38@gmail.com>, Rene Mayorga <rmayorga@debian.org.sv>
+Standards-Version: 3.8.0
Homepage: http://search.cpan.org/dist/POE-Component-Client-DNS/
Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/libpoe-component-client-dns-perl/
-Vcs-Browser: http://svn.debian.org/wsvn/pkg-perl/trunk/libpoe-component-client-dns-perl/
+Vcs-Browser: http://svn.debian.org/viewsvn/pkg-perl/trunk/libpoe-component-client-dns-perl/
Package: libpoe-component-client-dns-perl
Architecture: all
diff -pruN libpoe-component-client-dns-perl-1.00/debian/copyright libpoe-component-client-dns-perl-1.01/debian/copyright
--- libpoe-component-client-dns-perl-1.00/debian/copyright 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/copyright 2008-11-30 00:50:00.000000000 -0600
@@ -1,7 +1,11 @@
-This package was debianized by Steve Kowalik <stevenk@debian.org> on
-Sun, 15 Jul 2001 12:24:15 +1000.
-It was downloaded from: http://search.cpan.org/dist/POE-Component-Client-DNS/
-Upstream Author: Rocco Caputo <rcaputo@cpan.org>.
+Format-Specification:
+ http://wiki.debian.org/Proposals/CopyrightFormat?action=recall&rev=196
+Upstream-Author: Rocco Caputo <rcaputo@cpan.org>
+Packaged-By: Steve Kowalik <stevenk@debian.org>
+Upstream-Name: POE-Component-Client-DNS
+Original-Source-Location: http://search.cpan.org/dist/POE-Component-Client-DNS/
+Original-Source-Command: uscan --force-download
+Original-Source-Depends: devscripts
Files: *
Copyright: © 1999-2008 Rocco Caputo. All rights are reserved.
@@ -14,14 +18,24 @@ License: Artistic | GPL-1+
terms as Perl itself.
Files: debian/*
-Copyright: © 2008 Debian Perl Group
- <pkg-perl-maintainers@lists.alioth.debian.org>
+Copyright: © 2008 Martín Ferrari <Tincho@debian.org>
+ © 2008 gregor herrmann <gregoa@debian.org>
© 2006 Michael Ablassmeier <abi@debian.org>
© 2001-2005 Steve Kowalik <stevenk@debian.org>
License: Other
It is assumed that the previous maintainers did choose a license compatible
with the software.
-The GPL and Artistic licenses can be found under
-/usr/share/common-licenses/{GPL,Artistic} on Debian systems.
+License: Artistic
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the Artistic License, which comes with Perl.
+ On Debian GNU/Linux systems, the complete text of the Artistic License
+ can be found in /usr/share/common-licenses/Artistic
+License: GPL-1+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 1, or (at your option)
+ any later version.
+ On Debian GNU/Linux systems, the complete text of the GNU General
+ Public License can be found in `/usr/share/common-licenses/GPL'
diff -pruN libpoe-component-client-dns-perl-1.00/debian/patches/fail_gracefully_without_network.patch libpoe-component-client-dns-perl-1.01/debian/patches/fail_gracefully_without_network.patch
--- libpoe-component-client-dns-perl-1.00/debian/patches/fail_gracefully_without_network.patch 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/patches/fail_gracefully_without_network.patch 1969-12-31 18:00:00.000000000 -0600
@@ -1,44 +0,0 @@
-Index: libpoe-component-client-dns-perl/t/06_hosts.t
-===================================================================
---- libpoe-component-client-dns-perl.orig/t/06_hosts.t
-+++ libpoe-component-client-dns-perl/t/06_hosts.t
-@@ -10,6 +10,9 @@ sub POE::Kernel::ASSERT_DEFAULT () { 1 }
- use POE qw(Component::Client::DNS);
- use Test::More tests => 3;
-
-+require Net::DNS;
-+my $can_resolve = Net::DNS::Resolver->new->search("poe.perl.org");
-+
- use constant HOSTS_FILE => "./test-hosts";
-
- my $resolver = POE::Component::Client::DNS->spawn(
-@@ -45,10 +48,14 @@ sub start_tests {
- sub response_no_hosts {
- my $response = $_[ARG0];
- my $address = a_data($response);
-+ SKIP: {
-+ skip "Can't resolve with Net::DNS, network probably not available", 1
-+ unless($can_resolve);
- ok(
- $address eq "66.33.204.143",
- "lookup without hosts file ($address)"
- );
-+ }
-
- # 2. Test with a hosts file that contains a host match.
- unlink HOSTS_FILE; # Changes inode!
-@@ -87,10 +94,14 @@ sub response_hosts_match {
- sub response_hosts_nomatch {
- my $response = $_[ARG0];
- my $address = a_data($response);
-+ SKIP: {
-+ skip "Can't resolve with Net::DNS, network probably not available", 1
-+ unless($can_resolve);
- ok(
- $address eq "66.33.204.143",
- "lookup without hosts file match ($address)"
- );
-+ }
-
- unlink HOSTS_FILE;
- }
diff -pruN libpoe-component-client-dns-perl-1.00/debian/patches/fix_pod.patch libpoe-component-client-dns-perl-1.01/debian/patches/fix_pod.patch
--- libpoe-component-client-dns-perl-1.00/debian/patches/fix_pod.patch 1969-12-31 18:00:00.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/patches/fix_pod.patch 2008-11-30 00:50:00.000000000 -0600
@@ -0,0 +1,14 @@
+Author: gregor herrmann <gregoa@debian.org>
+Description: fix POD error
+
+--- a/DNS.pm
++++ b/DNS.pm
+@@ -690,6 +690,8 @@
+
+ $poco_client_dns->resolver()->port(1153);
+
++=back
++
+ =head1 RESPONSE MESSAGES
+
+ POE::Component::Client::DNS responds in one of two ways. Its
diff -pruN libpoe-component-client-dns-perl-1.00/debian/patches/series libpoe-component-client-dns-perl-1.01/debian/patches/series
--- libpoe-component-client-dns-perl-1.00/debian/patches/series 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/patches/series 2008-11-30 00:50:00.000000000 -0600
@@ -1 +1,2 @@
-fail_gracefully_without_network.patch
+fix_pod.patch
+use_netdns_instead_of_harcode_ips.patch
diff -pruN libpoe-component-client-dns-perl-1.00/debian/patches/use_netdns_instead_of_harcode_ips.patch libpoe-component-client-dns-perl-1.01/debian/patches/use_netdns_instead_of_harcode_ips.patch
--- libpoe-component-client-dns-perl-1.00/debian/patches/use_netdns_instead_of_harcode_ips.patch 1969-12-31 18:00:00.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/patches/use_netdns_instead_of_harcode_ips.patch 2008-11-30 00:50:00.000000000 -0600
@@ -0,0 +1,37 @@
+Author: Rene Mayorga <rmayorga@debian.org.sv>
+Description: Use Net::DNS to get poe.perl.org's IP Address
+
+--- libpoe-component-client-dns-perl.orig/t/06_hosts.t
++++ libpoe-component-client-dns-perl/t/06_hosts.t
+@@ -13,6 +13,13 @@
+ require Net::DNS;
+ my $can_resolve = Net::DNS::Resolver->new->search("poe.perl.org");
+
++my $addr;
++if ($can_resolve) {
++ foreach ($can_resolve->answer) {
++ $addr = $_->address unless $_->type ne "A";
++ }
++}
++
+ use constant HOSTS_FILE => "./test-hosts";
+
+ my $resolver = POE::Component::Client::DNS->spawn(
+@@ -52,7 +59,7 @@
+ skip "Can't resolve with Net::DNS, network probably not available", 1
+ unless($can_resolve);
+ ok(
+- ($address eq "67.207.145.70") || ($address eq "208.97.190.64"),
++ $address eq $addr,
+ "lookup with no hosts file ($address)"
+ );
+ }
+@@ -98,7 +105,7 @@
+ skip "Can't resolve with Net::DNS, network probably not available", 1
+ unless($can_resolve);
+ ok(
+- ($address eq "67.207.145.70") || ($address eq "208.97.190.64"),
++ $address eq $addr,
+ "lookup with hosts file but no match ($address)"
+ );
+ }
diff -pruN libpoe-component-client-dns-perl-1.00/debian/README.source libpoe-component-client-dns-perl-1.01/debian/README.source
--- libpoe-component-client-dns-perl-1.00/debian/README.source 1969-12-31 18:00:00.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/README.source 2008-11-30 00:50:00.000000000 -0600
@@ -0,0 +1,5 @@
+This package uses quilt to manage all modifications to the upstream
+source. Changes are stored in the source package as diffs in
+debian/patches and applied during the build.
+
+See /usr/share/doc/quilt/README.source for a detailed explanation.
diff -pruN libpoe-component-client-dns-perl-1.00/debian/rules libpoe-component-client-dns-perl-1.01/debian/rules
--- libpoe-component-client-dns-perl-1.00/debian/rules 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/debian/rules 2008-11-30 00:50:00.000000000 -0600
@@ -1,59 +1,25 @@
#!/usr/bin/make -f
-include /usr/share/quilt/quilt.make
-
-# Uncomment this to turn on verbose mode.
-#export DH_VERBOSE=1
-# If set to a true value then MakeMaker's prompt function will
-# always return the default without waiting for user input.
-export PERL_MM_USE_DEFAULT=1
-
-PACKAGE = $(shell dh_listpackages)
-PERL ?= /usr/bin/perl
-TMP = $(CURDIR)/debian/$(PACKAGE)
+include /usr/share/quilt/quilt.make
build: build-stamp
build-stamp: $(QUILT_STAMPFN)
- dh_testdir
- $(PERL) Makefile.PL INSTALLDIRS=vendor
- $(MAKE)
- $(MAKE) test
+ dh build
touch $@
clean: unpatch
- dh_testdir
- dh_testroot
- dh_clean build-stamp install-stamp
- [ ! -f Makefile ] || $(MAKE) realclean
-
-install:
- dh_testdir
- dh_testroot
- dh_clean -k
- $(MAKE) install DESTDIR=$(TMP) PREFIX=/usr
- [ ! -d $(TMP)/usr/lib/perl5 ] || \
- rmdir --ignore-fail-on-non-empty --parents --verbose \
- $(TMP)/usr/lib/perl5
+ dh $@
+
+install: install-stamp
+install-stamp: build-stamp
+ dh install
touch $@
binary-arch:
-# We have nothing to do here for an architecture-independent package
-binary-indep: build install
- dh_testdir
- dh_testroot
- dh_installdocs README
- dh_installchangelogs CHANGES
- dh_perl
- dh_compress
- dh_fixperms
- dh_installdeb
- dh_gencontrol
- dh_md5sums
- dh_builddeb
+binary-indep: install
+ dh $@
-source diff:
- @echo >&2 'source and diff are obsolete - use dpkg-source -b'; false
+binary: binary-arch binary-indep
-binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary
+.PHONY: binary binary-arch binary-indep install clean build
diff -pruN libpoe-component-client-dns-perl-1.00/DNS.pm libpoe-component-client-dns-perl-1.01/DNS.pm
--- libpoe-component-client-dns-perl-1.00/DNS.pm 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/DNS.pm 2008-11-30 00:50:00.000000000 -0600
@@ -1,4 +1,4 @@
-# $Id: DNS.pm 64 2007-01-06 18:12:47Z rcaputo $
+# $Id: DNS.pm 68 2008-10-29 16:18:54Z rcaputo $
# License and documentation are after __END__.
package POE::Component::Client::DNS;
@@ -6,7 +6,7 @@ package POE::Component::Client::DNS;
use strict;
use vars qw($VERSION);
-$VERSION = '1.00';
+$VERSION = '1.01';
use Carp qw(croak);
diff -pruN libpoe-component-client-dns-perl-1.00/META.yml libpoe-component-client-dns-perl-1.01/META.yml
--- libpoe-component-client-dns-perl-1.00/META.yml 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/META.yml 2008-11-30 00:50:00.000000000 -0600
@@ -1,16 +1,16 @@
--- #YAML:1.0
name: POE-Component-Client-DNS
-version: 1.00
+version: 1.01
abstract: Non-blocking/concurrent DNS queries using Net::DNS and POE
license: perl
-generated_by: ExtUtils::MakeMaker version 6.31
+author:
+ - Rocco Caputo <rcaputo@cpan.org>
+generated_by: ExtUtils::MakeMaker version 6.44
distribution_type: module
requires:
Net::DNS: 0.59
POE: 0.31
Test::More: 0
meta-spec:
- url: http://module-build.sourceforge.net/META-spec-v1.2.html
- version: 1.2
-author:
- - Rocco Caputo <rcaputo@cpan.org>
+ url: http://module-build.sourceforge.net/META-spec-v1.3.html
+ version: 1.3
diff -pruN libpoe-component-client-dns-perl-1.00/t/06_hosts.t libpoe-component-client-dns-perl-1.01/t/06_hosts.t
--- libpoe-component-client-dns-perl-1.00/t/06_hosts.t 2008-11-30 00:51:11.000000000 -0600
+++ libpoe-component-client-dns-perl-1.01/t/06_hosts.t 2008-11-30 00:50:00.000000000 -0600
@@ -1,5 +1,5 @@
#!/usr/bin/perl
-# $Id: 06_hosts.t 61 2006-10-17 16:35:24Z rcaputo $
+# $Id: 06_hosts.t 67 2008-10-15 03:18:31Z rcaputo $
# vim: filetype=perl
# Test the hosts file stuff.
@@ -10,6 +10,9 @@ sub POE::Kernel::ASSERT_DEFAULT () { 1 }
use POE qw(Component::Client::DNS);
use Test::More tests => 3;
+require Net::DNS;
+my $can_resolve = Net::DNS::Resolver->new->search("poe.perl.org");
+
use constant HOSTS_FILE => "./test-hosts";
my $resolver = POE::Component::Client::DNS->spawn(
@@ -45,10 +48,14 @@ sub start_tests {
sub response_no_hosts {
my $response = $_[ARG0];
my $address = a_data($response);
- ok(
- $address eq "66.33.204.143",
- "lookup without hosts file ($address)"
- );
+ SKIP: {
+ skip "Can't resolve with Net::DNS, network probably not available", 1
+ unless($can_resolve);
+ ok(
+ ($address eq "67.207.145.70") || ($address eq "208.97.190.64"),
+ "lookup with no hosts file ($address)"
+ );
+ }
# 2. Test with a hosts file that contains a host match.
unlink HOSTS_FILE; # Changes inode!
@@ -68,7 +75,7 @@ sub response_hosts_match {
my $address = a_data($response);
ok(
$address eq "123.456.789.012",
- "lookup without hosts file match ($address)"
+ "lookup when hosts file matches ($address)"
);
# 3. Test against a hosts file without a host match.
@@ -87,10 +94,14 @@ sub response_hosts_match {
sub response_hosts_nomatch {
my $response = $_[ARG0];
my $address = a_data($response);
- ok(
- $address eq "66.33.204.143",
- "lookup without hosts file match ($address)"
- );
+ SKIP: {
+ skip "Can't resolve with Net::DNS, network probably not available", 1
+ unless($can_resolve);
+ ok(
+ ($address eq "67.207.145.70") || ($address eq "208.97.190.64"),
+ "lookup with hosts file but no match ($address)"
+ );
+ }
unlink HOSTS_FILE;
}
Attachment:
signature.asc
Description: Digital signature