On Sat, 16 Feb 2008 00:11:28 +0000, Dominic Hargreaves wrote: > > > carp()ing isn't really appropriate here either. The error only needs to > > > appear if send_by_sendmail is used, and send should select sendmail if > > > available, and not otherwise. > > Right, that would involve moving the test into to send_by_sendmail() > > method. > Here are the possibilities: > 1) sendmail preparation step looks for a sendmail, and sets the default > send method to 'smtp', like on win32, if no sendmail found: > 2) as you suggested, replace croak with carp: > 3) Check in send_by_sendmail (and no check in the place where croak used > to be) > None of those options are more than a few lines of patch (so much so > that I haven't bothered to preserve the code used to test them) but I > think on reflection I prefer option three, Agreed. > Any other comments? If we can agree on the third, I'll update the > upstream bug with a patch, and get our package in shape and uploaded to > fix this rather annoying bug :) I think that's a good idea. Cheers, gregor -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `- NP: Jerry Lee Lewis: Crazy Arms
Attachment:
signature.asc
Description: Digital signature