Re: Bug#441184: svn-inject (version 0.6.21) fails to perform $chdir

["Jeremiah C. Foster" <jeremiah@jeremiahfoster.com>]

Sat, Oct 27, 2007 at 12:31:47PM +0300:  Eddy Petri??or mangled some bits into this alignment:
 
> >> Second, I would like to ask you to try to reproduce the bug with the
> >> version in
> >> experimental 0.6.22 [1] since svn-inject has undergone a siginificant
> >> ammount of
> >> changes in the 0.6.22 release.
> >>

The bug is reproducible for me. svn-inject incorrectly states the current
working directory.

> >> Also I would really appreciate any feedback (be it positive or
> >> negative) on the
> >> release from experimental (the release is in experimental because
> >> there were
> >> many changes in this release and an incompatible change wrt to
> >> .svn/deb-layout[2], not because of some stability issues).

I think it is a much better peice of software now. It asks for passwords
a lot, and one is not sure what is happening in the background, but these
svn tools have always done that.

I think that a couple of other bugs I noticed are gone, and the scripts seem
to work accurately now, at least up until the point the do the $chdir and 
print the working dir and "have fun!" message. :)

 
> > Thanks for all the fixes, did you use my patch? Or was in not what you
> > needed?
> 
> No, I haven't used yet your patch and I am not sure if the bug is still
> reproducible, thus the mail :-)
> 
> If the bug is still present I would rather find the root of the problem and try
> to fix that, that's where your patch might help - the investigation.

I am pretty much convinced that my patch addresses the root of the problem. I 
am nearly certain it is on line 387 where the chdir command is called:

chdir $trunkdir if($trunkdir);

In that line, you change to the $trunkdir if it exists, but nothing happens if 
it doesn't, errors are not handled. So, the software goes on and thinks it is 
somewhere that it isn't. I addressed this with error checking, but you may want
to find out why this is happening. 

So a new test case might be: Before line 387, what is the value of $trunkdir?
If we try to chdir to $trunkdir what happens? Is this behavior necessary?

I hope all this helps!

  Jeremiah