[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Fwd: Package libcdk-perl added to repository





On Aug 10, 2007, at 8:59 AM, Damyan Ivanov wrote:

-=| Jeremiah Foster, 10.08.2007 09:15 |=-
I have added libcdk-perl to the repository and tracked down all the
lintian errors. Hopefully it is ready to be uploaded, I would welcome
any feedback.

I reorganized debian/changelog a bit and fixed debian/watch.

Further notes:
1)
$ diffstat -w 70 /var/cache/pbuilder/result/libcdk- perl_4.9.10-2.diff.gz
 Cdk/Viewer.pm    |    2 -
 Makefile.PL      |    6 ++-
debian/changelog | 79 ++++++++++++++++++++++++++++++++++++++++++ +++
 debian/compat    |    1
 debian/control   |   23 +++++++++++++
 debian/copyright |   40 ++++++++++++++++++++++
 debian/rules     |   47 ++++++++++++++++++++++++++
 debian/watch     |    4 ++
 8 files changed, 199 insertions(+), 3 deletions(-)

Please convert the changes to the upstream source (if they are
intentional) to a patch system. I prefer quilt, others use dpatch.

I am reading about quilt now, I have not used it before. I did not realize there were changes to the upstream source, and I certainly did not make any changes. I assume you are referring to the Makefile.PL and CDK/Viewer.pm. I can dig around and see if I can find previous versions and compare the changes, but there were no (intentional) changes on my part.

Yes, the package currently in the archive contains these changes too.
Having them in separate patches makes it easier to review/drop/ send them and helps ensure there are no unintended changes in the upstream sources.

It appears there are unintended changes - not sure what the next step should be. Please advise.

2)
There is one change from -1, which is not described in debian/ changelog.
To see difference between two diffs use interdiff.

I will fix this.

Otherwise the package looks OK to me. Fix the above and I'll upload.

	Jeremiah



Reply to: