[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Package libcdk-perl added to repository



-=| Jeremiah Foster, 10.08.2007 09:15 |=-
> I have added libcdk-perl to the repository and tracked down all the
> lintian errors. Hopefully it is ready to be uploaded, I would welcome
> any feedback.

I reorganized debian/changelog a bit and fixed debian/watch.

Further notes:
1)
$ diffstat -w 70 /var/cache/pbuilder/result/libcdk-perl_4.9.10-2.diff.gz
 Cdk/Viewer.pm    |    2 -
 Makefile.PL      |    6 ++-
 debian/changelog |   79 +++++++++++++++++++++++++++++++++++++++++++++
 debian/compat    |    1
 debian/control   |   23 +++++++++++++
 debian/copyright |   40 ++++++++++++++++++++++
 debian/rules     |   47 ++++++++++++++++++++++++++
 debian/watch     |    4 ++
 8 files changed, 199 insertions(+), 3 deletions(-)

Please convert the changes to the upstream source (if they are
intentional) to a patch system. I prefer quilt, others use dpatch.

Yes, the package currently in the archive contains these changes too.
Having them in separate patches makes it easier to review/drop/send them
and helps ensure there are no unintended changes in the upstream sources.

2)
There is one change from -1, which is not described in debian/changelog.
To see difference between two diffs use interdiff.

Otherwise the package looks OK to me. Fix the above and I'll upload.

> Does one also send a message to the BTS when a package is uploaded as
> well? (Aside from the already sent ITA.)

No. The special (closes: #bugnumber) entry in debian/changelog (which in
turn appears in the .changes file) is detected by the archive software
and the bug is automatically closed when the new version is uploaded.

-- 
dam            JabberID: dam@jabber.minus273.org

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: