Re: Bug#365471: libpdf-report-perl: addImgScaled() method disregards the scaling parameter does a simple addImg()
On Sun, Apr 30, 2006 at 06:26:40PM +0200, gregor herrmann wrote:
> I've therefore applied the patch to Report.pm in the Debian Perl
> Group's svn repository and reported it at rt.cpan.org:
> http://rt.cpan.org/Public/Bug/Display.html?id=18992
Hi Gregor,
I suppose you didn't notice that libpdf-report-perl is currently using
dpatch for managing the patches.
While I'm aware that there are different opinions on whether dpatch
(and other such patch systems) are a good idea, I suppose everybody can
agree that mixing dpatch and 'straightforward' .diff.gz patching gives
the worst of the both worlds.
Please consider making this patch into a dpatch as well or removing
the dpatch framework. I introduced it in 1.30-4 because I thought the
.diff.gz was getting confusing with four independent patches.
I wonder if we (as in pkg-perl-maintainers) should have a policy about
patch systems? If people think that the SVN history keeps patches
separate enough, that's of course fine by me. The only situation where
that doesn't apply is when the patches are older than the first import
to our SVN repository.
Cheers,
--
Niko Tyni ntyni@iki.fi
Reply to: