[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

install-info vs. perl 5.8



[CC me if you reply to debian-dpkg]

So... apparently, because of changes in Perl, an existing bug has become
much more easily triggered.  It won't be fixed without a major regex
rewrite.  Thus, I think it's reasonable to work around it.  The patch even
improves the performance of install-info at no loss of functionality...

--- /usr/sbin/install-info	2002-07-14 16:19:49.000000000 -0400
+++ install-info	2002-09-05 13:08:05.000000000 -0400
@@ -146,7 +146,7 @@
 	}
 
         close(IF); &checkpipe;
-        if ($asread =~ m/(\*\s*[^:]+:\s*\(([^\)]+)\).*\. *.*\n){2,}/) {
+        if ($asread =~ m/(\*\s*[^:]+:\s*\(([^\)]+)\).*\. *.*\n){2}/) {
             $infoentry= $asread;
             $multiline= 1;
             $fileinentry = $2;


This changes the value if $fileinentry, potentially, but it's dead on this
code path anyway.  It'll always be reset in the if (length ($infoentry))
block below.  Sound reasonable?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer



Reply to: