[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1088403: marked as done (libreoffice: FTBFS with zlib-ng.)

Your message dated Sat, 10 May 2025 23:00:21 +0000
with message-id <E1uDtB7-00Er7X-S5@fasolo.debian.org>
and subject line Bug#1088403: fixed in libreoffice 4:25.8.0~alpha1-1
has caused the Debian Bug report #1088403,
regarding libreoffice: FTBFS with zlib-ng.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1088403: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1088403
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libreoffice
Version: 4:24.8.3-2
Severity: important
Tags: sid patch
control: affects -1 src:zlib-ng
control: forwarded -1 https://gerrit.libreoffice.org/c/core/+/177440
User: zlib-ng@tracker.debian.org
Usertags: zlib-ng-ftbfs

The testsuite of libreoffice fails if zlib-ng is used. One of the tests
creates a png file on the fly and its size is different due the zlib
compression.
The patch attached works around the issue by comparing a less-than value
instead of exact size.

Sebastian

From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Tue, 26 Nov 2024 22:57:38 +0100
Subject: [PATCH] vcl/qa/cppunit/GraphicTest: Don't test for the exact size of
 the png file.

Building with zlib-ng instead of zlib leads to the following error in the
testsuite:

| [_RUN_____] testSwappingGraphic_PNG_WithGfxLink::TestBody
| ./vcl/qa/cppunit/GraphicTest.cxx:528:testSwappingGraphic_PNG_WithGfxLink::TestBody
| equality assertion failed
| - Expected: 319
| - Actual  : 318

The different implementation of deflate() leads to a different result.

Use an approximation of the expected size instead of the exact value.

Change-Id: I173164bc3b1e6dd37eb48fe42093527069a54075
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
 vcl/qa/cppunit/GraphicTest.cxx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/vcl/qa/cppunit/GraphicTest.cxx b/vcl/qa/cppunit/GraphicTest.cxx
index 3821c31dcf8e3..f6828ea7d8c7d 100644
--- a/vcl/qa/cppunit/GraphicTest.cxx
+++ b/vcl/qa/cppunit/GraphicTest.cxx
@@ -526,7 +526,8 @@ CPPUNIT_TEST_FIXTURE(GraphicTest, testSwappingGraphic_PNG_WithGfxLink)
     BitmapChecksum aChecksumBeforeSwapping = aGraphic.GetChecksum();
 
     CPPUNIT_ASSERT_EQUAL(true, aGraphic.IsGfxLink());
-    CPPUNIT_ASSERT_EQUAL(sal_uInt32(319), aGraphic.GetGfxLink().GetDataSize());
+    // Expect the the compressed png is be at least W * H / 2
+    CPPUNIT_ASSERT_LESS(sal_uInt32(120 * 100 / 2), aGraphic.GetGfxLink().GetDataSize());
 
     // We loaded the Graphic and made it available
     CPPUNIT_ASSERT_EQUAL(false, aGraphic.ImplGetImpGraphic()->isSwappedOut());
-- 
2.45.2

--- End Message ---
--- Begin Message --- 
Source: libreoffice
Source-Version: 4:25.8.0~alpha1-1
Done: Rene Engelhard <rene@debian.org>

We believe that the bug you reported is fixed in the latest version of
libreoffice, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1088403@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rene Engelhard <rene@debian.org> (supplier of updated libreoffice package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 11 May 2025 00:07:19 +0200
Source: libreoffice
Architecture: source
Version: 4:25.8.0~alpha1-1
Distribution: experimental
Urgency: medium
Maintainer: Debian LibreOffice Maintainers <debian-openoffice@lists.debian.org>
Changed-By: Rene Engelhard <rene@debian.org>
Closes: 1088403
Changes:
 libreoffice (4:25.8.0~alpha1-1) experimental; urgency=medium
 .
   * New upstream snapshot
     - fixes build with zlib-ng (closes: #1088403)
 .
   * debian/rules:
     - remove bookworm-backports handling, add trixie-backports
     - disable dwz, breaks now and didn't have big effect anyway
   * debian/control*.in, debian/*.preinst.in: remove bookworm->trixie Pre-Depends:
     and preinsts
   * debian/libuno-sal3t64.symbols: ... move
   * debian/libuno-sal3t64.symbols.in: ... here. Add Depends on
     libreoffice-sal-private-abi (= @UREPACKAGEVERSION@) for (symver)@PRIVATE*
   * debian/control.ure.in: add Provides: for above
Checksums-Sha1:
 0749700445eb829381785063cededfe306f46f78 37465 libreoffice_25.8.0~alpha1-1.dsc
 7d27f63b839181d02c5fe7689b6bc97bdf8a4231 59180576 libreoffice_25.8.0~alpha1.orig-helpcontent2.tar.xz
 0d4fccbf1e452f54cbbcff9c9530b43c55f865c4 231158056 libreoffice_25.8.0~alpha1.orig-translations.tar.xz
 ae16de2ab300fe6964b262ce392897656adb036d 283587424 libreoffice_25.8.0~alpha1.orig.tar.xz
 17047a30f3f9807078f757b67f3f9339ab8659a1 833 libreoffice_25.8.0~alpha1.orig.tar.xz.asc
 79fd22ebabda80206ea9465dffdb9e42f3a8fc9c 28682656 libreoffice_25.8.0~alpha1-1.debian.tar.xz
 cc4946133ae94232e7fc4647d15fadf41db1050d 25952 libreoffice_25.8.0~alpha1-1_source.buildinfo
Checksums-Sha256:
 c4c4a00ecde38414cb0be7e31f97b123224fa0261586bd8b543f26275c211edf 37465 libreoffice_25.8.0~alpha1-1.dsc
 e18ad22b0254aae3e5af9f3d668b1a47c9ddbff104760b55c79c655a06ce754d 59180576 libreoffice_25.8.0~alpha1.orig-helpcontent2.tar.xz
 61d64efce1b536ee66c25f418498bda8af9c3b05a6e0c32d27249d8a62282a92 231158056 libreoffice_25.8.0~alpha1.orig-translations.tar.xz
 1de3c66cd6ffd8a382b812cd2e38373ec7c2ca396c2ea5714f198169c5d638b6 283587424 libreoffice_25.8.0~alpha1.orig.tar.xz
 ca90aff5106e8f3232453744480b9a8771c6e42950c87d5fcac58620b68481ad 833 libreoffice_25.8.0~alpha1.orig.tar.xz.asc
 60f790c5dacb66baa0438d6dfb686afede9d2c7bd3677d5ce00bed334fab8be4 28682656 libreoffice_25.8.0~alpha1-1.debian.tar.xz
 bb0395e575887856124c8eb229d93598f9bdbe8eaa99fdd3b69d382b4271f2ba 25952 libreoffice_25.8.0~alpha1-1_source.buildinfo
Files:
 dc0fdfc629c3ed53fc9360fbff720d5a 37465 editors optional libreoffice_25.8.0~alpha1-1.dsc
 c31ed6c66e03451f36f2f179d75ad4ea 59180576 editors optional libreoffice_25.8.0~alpha1.orig-helpcontent2.tar.xz
 119b429ce62c5e101bb722f1962f4b85 231158056 editors optional libreoffice_25.8.0~alpha1.orig-translations.tar.xz
 92eeecc46e71a60b883838193cfc0cf6 283587424 editors optional libreoffice_25.8.0~alpha1.orig.tar.xz
 a76c1b8734315f68f3e6f5097f02d9c1 833 editors optional libreoffice_25.8.0~alpha1.orig.tar.xz.asc
 71719fa4662d07081762dcf12512cbde 28682656 editors optional libreoffice_25.8.0~alpha1-1.debian.tar.xz
 ba825157c2a66f439b6f1d329fb43725 25952 editors optional libreoffice_25.8.0~alpha1-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE4S3qRnUGcM+pYIAdCqBFcdA+PnAFAmgf0R0QHHJlbmVAZGVi
aWFuLm9yZwAKCRAKoEVx0D4+cPiJD/4wOaH5g8Bp0qetEJ7vxgO1BJnPWsr+KsUg
CltTcd/zvure7I9X4mxfEk9JTL98bq85fih0hBTKU4bU0/7B60M4tazx5EmKcYgd
7yg44CcKIUzPANcBDcGbcQ8RlEnIEQ6oA90UEvktMQdNq6GMYl/mQzoB/JmO4emb
zPN+/5LrQCGJgCqc68dU6hFppVwTFWPdFPaDCZXbyF//RCuepaT8ncGmwLt5SnS1
prFsigfV6Kl2l3X6hA92kdSR/k66Ly25Q9TUPOkSU0So92/EvCnB2Qku+9TnKiyb
F2JfRR09iXp93CWsLT2hVCyE6UIVruKqqX4Erbugh8y2UF3FKT0Pr8U6/8PRmI1e
kPhbJ0ugPzZt+b4Oi3JKZJs6B/d/vARqJOGCQCNCXDy9hq1RSFzuG3KiDAeoEcT0
RmhE6AvXDzGUdD7RJOK3Rs6lCg+O873If3wARaLUoh91hU6KK7dAWcYpip/tkJLT
a9+rHqAulOD6DjP9qyFh/Lb0VdbPcUIlm9OoV8YehXEbEZDxi1YGfP0zUpvIQ4eK
PToUKq77AV5w8Sv4eKduPO+iHi0XOK295tOD+ajXqJ/hDwG6udT/zJ9OAgQ9xllD
HLrn7TZGeuzYIAIW46gZYaui8T5TCvrdF07TFXJ0jOOz1V+wtl2ALpNAcc9dS4+x
qQV2mq7PjA==
=3/qW
-----END PGP SIGNATURE-----

Attachment: pgpxJtJ0G74Rg.pgp
Description: PGP signature


--- End Message ---
Reply to: