[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#870477: marked as done (libreoffice-writer: Set cursor focus to the end of the mispelt word in Spelling dialog)

Your message dated Mon, 6 Nov 2023 18:54:02 +0100
with message-id <166e4222-5c27-49e5-9102-d7eeefcc8b5f@debian.org>
and subject line long fixed upstream long ago
has caused the Debian Bug report #870477,
regarding libreoffice-writer: Set cursor focus to the end of the mispelt word in Spelling dialog
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
870477: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870477
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libreoffice-writer
Version: 1:5.3.0~alpha1-1
Tags: a11y upstream
Owner: bugs@hypra.fr
User: bugs@hypra.fr
Usertags: hypra
Forwarded: https://bugs.documentfoundation.org/show_bug.cgi?id=102044

DESCRIPTION FROM UPSTREAM:

When the spelling dialog is opened and when a new mispelt word is highlighted, the cursor should return to the 'not in dictionary' text area so that a user can easily modify the word and a screen reader can read the mispelt word, as presently a a11y users cant know which of the text area words are mispelt

--- End Message ---
--- Begin Message --- 
Version: 1:6.3.0-1

Hi,
see https://bugs.documentfoundation.org/show_bug.cgi?id=102044#c4 (thanks bts-link :)): 

--- snip ---
In current LO versions, the cursor is already at the *beginning* of the misspelled word when the text field gets focus. 

Bibisecting shows that this was implemented in this commit:

commit 243b5b392906042ab03800e0b5765e6f3513372c
Author: Caolán McNamara
Date:   Fri Jun 14 21:56:44 2019 +0100

    weld SpellDialog
a) use EditEngine instead of TextEngine as the former can be hosted in a 
       foreign widget
b) use a SfxGrabBagItem to hold the custom spellchecking info inside the 
       EditEngine
    c) in longer paragraphs the current word is now auto-scrolled into view
    d) rename Invalidate to InvalidateDialog

    Change-Id: Ic6db019c32cdfd5f354c58ee7394fdaa040b86e1
    Reviewed-on: https://gerrit.libreoffice.org/74535
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara
    Tested-by: Caolán McNamara
-> closing as fixed (It's the beginning of the word, not the end, but even in the discussion in this ticket, there were different opinions, so I think that should be OK.) 

(In reply to Yousuf Philips (jay) (retired) from comment #0)
> When the spelling dialog is opened and when a new mispelt word is
> highlighted, the cursor should return to the 'not in dictionary' text area > so that a user can easily modify the word and a screen reader can read the 
> mispelt word, as presently a a11y users cant know which of the text area
> words are mispelt.
Not sure whether the cursor should automatically return to the text field, since other use cases might prefer e.g. having one of the buttons focused by default so that e.g. correcting/ignoring/adding words using the keyboard is faster. In any case, Alt+N can be used to quickly switch focus to the text edit with the misspelled word. (I can't find it now, but I think there might even have been another bug report requesting that focus should be on a certain button.) 


Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 142e7d985f2f6cdb1e37dc0540d77e1fbd6f1bfd
CPU threads: 12; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
--- snip ---

In *2019*.
Looking where that commit first appeared it's at least in 6.3.0. Didn't look further to look on which exact alpha/beta it was :-) 

Regards,

Rene

--- End Message ---
Reply to: