[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#990327: marked as done (cppunit: reproducible-builds: Example Makefiles embed build paths and binary paths)

Your message dated Fri, 10 Sep 2021 22:05:00 +0000
with message-id <E1mOodo-0004JN-2W@fasolo.debian.org>
and subject line Bug#990327: fixed in cppunit 1.15.1-3
has caused the Debian Bug report #990327,
regarding cppunit: reproducible-builds: Example Makefiles embed build paths and binary paths
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
990327: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990327
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: cppunit
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath usrmerge shell
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path, several binary paths, and the value of the SHELL
variable are embedded in example Makefiles shipped in the package:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/cppunit.html

  /usr/share/doc/libcppunit-doc/examples/ClockerPlugIn/Makefile.gz

  ACLOCAL·=·${SHELL}·'/build/1st/cppunit-1.15.1/missing'·aclocal-1.16
  vs.
  ACLOCAL·=·${SHELL}·'/build/2/cppunit-1.15.1/2nd/missing'·aclocal-1.16

  GREP·=·/bin/grep
  vs.
  GREP·=·/usr/bin/grep

  SHELL·=·/bin/bash
  vs.
  SHELL·=·/bin/sh

Since these values may differ with the installed system, in order to use
the example Makefiles, a person would have to regenerate them from
Makefile.am or Makefile.in, which are also provided.

The attached patch adjusts debian/rules to remove the Makefiles before
running dh_compress.


If that is somehow not an option, an alternate option would be to
sanitize the Makefiles stripping the build path (or replacing with
/usr/src?), and possibly passing various variables to configure
(e.g. GREP=/bin/grep, SHELL=/bin/sh, ...).


Thanks for maintaining cppunit!


live well,
  vagrant

From e1714c24575d26671157ee54308a892fcf832a15 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 25 Jun 2021 19:14:10 +0000
Subject: [PATCH] debian/rules: Remove Makefiles to resolve reproducibility
 issues.

The build path, several binary paths, and the value of the SHELL
variable are embedded in a Makefile shipped in the package.

Since these values may differ with the installed system, in order to use
the example Makefiles, a person would have to regenerate them from
Makefile.am or Makefile.in, which are also provided.
---
 debian/rules | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/debian/rules b/debian/rules
index fc2f58a..9e54dce 100755
--- a/debian/rules
+++ b/debian/rules
@@ -40,3 +40,8 @@ override_dh_install-indep:
 	dh_installdocs -plibcppunit-doc doc/html
 	dh_installexamples -plibcppunit-doc examples/* debian/examples/*
 	rm -f debian/libcppunit-doc/usr/share/doc/libcppunit-doc/examples/simple/.gitignore
+
+override_dh_compress:
+	# Delete example Makefiles which contain variable build paths and binary paths
+	find debian/ -name Makefile -print -delete
+	dh_compress
-- 
2.32.0

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: cppunit
Source-Version: 1.15.1-3
Done: Mattia Rizzolo <mattia@debian.org>

We believe that the bug you reported is fixed in the latest version of
cppunit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 990327@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mattia Rizzolo <mattia@debian.org> (supplier of updated cppunit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 10 Sep 2021 23:00:23 +0200
Source: cppunit
Architecture: source
Version: 1.15.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian LibreOffice Maintainers <debian-openoffice@lists.debian.org>
Changed-By: Mattia Rizzolo <mattia@debian.org>
Closes: 883796 990327
Changes:
 cppunit (1.15.1-3) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Debian Janitor ]
   * Trim trailing whitespace.
   * Use secure URI in Homepage field.
   * Apply multi-arch hints.
     + libcppunit-dev: Add Multi-Arch: same.
     + libcppunit-doc: Add Multi-Arch: foreign.
 .
   [ Mattia Rizzolo ]
   * d/rules:
     + Do not install examples Makefile (that are autogenerated by automake
       anyway): they contain build-host-specific details and are unreproducible.
       Thanks to Vagrant Cascadian for the initial patch.  Closes: #990327
     + Make the logic for the indep/arch builds more obvious.
     + Move the installation parts from override_dh_install to debhelper
       .install files.
     + Temporarily set --doc-main-package to retain the behaviour pre-compat-11.
     + Install the FAQ file, and add a symlink in the right place so that the
       HTML docs resolve correctly to it.  Closes: #883796
     + Remove spurious hidden files from the examples, that should have
       never been there.
   * d/control:
     + Mark as Rules-Requires-Root: no.
     + Drop old obsoleted Replaces/Conflicts.
     + Use debhelper-compat(=10) and drop d/compat.
     + Bump Standards-Version to 4.6.0, no changes needed.
     + Bump debhelper compat level to 13:
       + Add d/not-installed for the new dh_missing helper.
     + Add Build-Depends-Indep:graphviz, to generate the png files used in the
       docs (previously we were shipping the .dot files instead, as the build
       system doesn't fail due to missing `dot`).
     + De-duplicate the binary package descriptions.
   * Use version=4 and https in debian/watch.
Checksums-Sha1:
 7545993d769ca85863510521f955e4d14f6c5770 2159 cppunit_1.15.1-3.dsc
 16c52341b70f7315322378aefabea9a19e3a0562 7584 cppunit_1.15.1-3.debian.tar.xz
 02126b5012c327e031d85ae5a3448d7963ef2768 8309 cppunit_1.15.1-3_amd64.buildinfo
Checksums-Sha256:
 c3c55c3e86ccbfb058f355e53532fb7c1afe5062a949e0f18110fe4d3570f344 2159 cppunit_1.15.1-3.dsc
 bd94ef114f976aa5f2c128fe69a493d8b54861032e004d53b6addc92050212f6 7584 cppunit_1.15.1-3.debian.tar.xz
 485958354e01df1bcb171f70c87c0099cce19812664ed837b18942ef9c07b5e0 8309 cppunit_1.15.1-3_amd64.buildinfo
Files:
 976eab0c8d599f2460fadf3b42720437 2159 devel optional cppunit_1.15.1-3.dsc
 ade3c1a4d77be31896b7ced2629a0b4b 7584 devel optional cppunit_1.15.1-3.debian.tar.xz
 5be381a1c0b1f521832d11eab3a8c3d7 8309 devel optional cppunit_1.15.1-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAmE7y8gACgkQCBa54Yx2
K63Cjg/+Pf6j+j3uWe0SSCckD1V0R9UNeKKPN2DmdSZKyU58yL/4IQYjhBJFMBuH
JN7mYI0QR4htN68i7q+BxPz+YJZgH+5PalyxkE6QW5seUGT7Sh1g5TeZopUW43Fa
Hot+aDsrLA3l6SHsq5SAMXpkyARXql/bJMzp2jjM47UlAAgLwv8gBtUnJa2Dmtqf
aE5kjqhb4qnaxkWNC5a0k4gRIXUTzn+BQj0tQkJktqsdpi6UtwVdbqLRN/ZWH1G1
p8vFNq+r81A8sYrXxJ+/DzyyVomil1H5dT0XcmFkmcgTyOVLjKxT2r9X/wnqXA9h
QQIeqF1d1WL1Fdpo45mqghWCzXPT3UjgfGZtMRIVMX3aC+yXY3+McLd4Tdu7+pqa
o3lV7++lRZeqn7LsBVlpwoVMAhBiGgm4CXWZphlMTg02TG8LuiBZtAA+BDr+qqJm
VZcv37AX7ZVN13APzW//OytNN+XzopUxc5R6/TBn4JLZHAabuEc7RK1K5u4I3z6R
PV35uusYK0AYluxXLYXKypwDaKWtI70W0gGSTowXSra0GIXBR7AC3bD+q+fmsf3U
vKKJ5z4N2hlEyXhAzAZyEJZK4JOKUzZCK30Rdq87Ale3h2BT3Ai3S04BJsArMDRJ
Jla/cSU5+ilfJz82WRNxhhCea16wVqT4Pu4PjkoWo+wPRMfKZcw=
=wI8c
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: