Bug#975481: Use libmariadb-dev instead of legacy libmariadbclient-dev

[Rene Engelhard <rene@debian.org>]

severity 975481 wishlist

tag 975481 + moreinfo

thanks

Am 22.11.20 um 19:15 schrieb Otto Kekäläinen:
> Package: libreoffice

How is this a normal bug? Please a bit more care when reporting bugs.

Either it's a wish or libmariadbclient-dev is supposed to be removed
soonish at which it would be at least important.

> I noticed the source package has references to libmariadbclient-dev:
> https://salsa.debian.org/search?search=libmariadbclient-dev&project_id=1012&group_id=2250

changelog is of a total obsolete version. Note the "bump
build-dependency on icu to >= 52 (see" and opencollada which isn't a
thing anymore even in buster.

The first rules part

ifneq (,$(filter mariadb, $(SYSTEM_STUFF)))
# deducted from default-libmysqlclient-dev Depends
BUILD_DEPS += , libmariadbclient-dev-compat
endif
MARIADBCONFIG=/usr/bin/mariadb_config

is not used as it's inside an ifeq "$(MYSQL_FLAVOUR)" "mariadb"
and MYSQL_FLAVOUR is set to default in rules (aka use default-libmysqlclient-dev).

The second rules part

ifeq "$(MYSQL_FLAVOUR)" "mysql"
perl -pi -e "s/(Build-Conflicts: .*)/\1,libmariadbclient-dev,/"
debian/control
endif
ifneq (nocheck,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))

is (as you see in the snippet) only used with MYSQL_FLAVOUR=mysql (which won't ever be set, will only bet set ever if it's "real" MySQL to be used)

Don't just grep for stuff but check what packages actually do.

> This is a deprecated package and you should instead use
> libmariadb-dev[1] or libmariadb-dev-compat if you need to build
> something old that does not find the correct soname otherwise.

Now to the real part.

So you want me to change 
libmariadbclient-dev-compat to libmariadb-dev-compat? Can do that, but as said there won't be any real effect here :)

Or do you also want to change the (effective) default-libmysqlclient-dev build-dep, too? That should probably also work?
The resulting libreoffice-sdbc-mysql at least ends up with a dependency on libmariadb3 anyway.
Note LO used mysql_config so needs to compat thingies.[1]

Regards,

Rene