Bug#948120: libreoffice: Incorrect conditional test to enable BUILD_NOGUI_PACKAGES

[Rene Engelhard <rene@debian.org>]

On Sat, Jan 04, 2020 at 10:19:13AM +0100, John Paul Adrian Glaubitz wrote:
> The build on ppc64 currently fails because debian/rules tries to execute some
> script code on ppc64 which is relevant for the OOO_NOGUI_ARCHS in debian/rules.

Yes.

> # remove lib*uilo.so in --nogui
> find debian/libreoffice-*-nogui/usr/lib/libreoffice/program/lib*uilo.so -exec rm {} \;

Note this works. Even when it is also operating on -nogui.

> # and (no UI, so not needed) not needed .desktop files
> find debian/libreoffice-*-nogui/usr/share/applications/*.desktop -exec rm {} \;
> find: ‘debian/libreoffice-*-nogui/usr/share/applications/*.desktop’: No such file or directory

And this not.

(And -nogui starts from a cp -ra from the "normal" packages.)

> make: *** [debian/rules:2699: debian/stampdir/install-arch] Error 1
> 
> I haven't verified it, but my suspicion is that the following conditional test is
> incorrect as the function findstring will match "ppc64" in OOO_NOGUI_ARCHS if
> it contains "ppc64el":

But...

> ifeq "$(ENABLE_GUI)" "y"
>   ifneq (,$(findstring $(DEB_HOST_ARCH),$(OOO_NOGUI_ARCHS)))
>     BUILD_NOGUI_PACKAGES=y
>   endif
> else

... this is just for "build -nogui *in addition* to the 'normal' packages".
In the "normal" packages .desktop should have been present so the find -exec rm
should work

> So, I suggest to use the function "filter" instead of "findstring" to fix this
> conditional test.

Maybe, but that (afaics) doesn't fix the real issue?

Regards,

Rene