[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#773919: marked as done (lightproof: please output locales in a stable order)

Your message dated Wed, 11 Sep 2019 16:49:00 +0000
with message-id <E1i85ng-000BX4-NS@fasolo.debian.org>
and subject line Bug#773919: fixed in lightproof 1.6-2
has caused the Debian Bug report #773919,
regarding lightproof: please output locales in a stable order
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
773919: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773919
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: lightproof
Version: 1.5+git20140515-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness

Hi!

While working on the “reproducible builds” effort [1], we have noticed
that your package failed to build reproducibly.

The source of variation is the random order of the list of locales as
written by make.py. The attached patch makes the order stable and enable
the package to build reproducibly according to my tests.

 [1]: https://wiki.debian.org/ReproducibleBuilds

-- 
Lunar                                .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

diff -Nru lightproof-1.5+git20140515/debian/changelog lightproof-1.5+git20140515/debian/changelog
--- lightproof-1.5+git20140515/debian/changelog	2014-05-15 13:28:38.000000000 +0000
+++ lightproof-1.5+git20140515/debian/changelog	2014-12-25 16:07:15.000000000 +0000
@@ -1,3 +1,9 @@
+lightproof (1.5+git20140515-1.0~reproducible1) UNRELEASED; urgency=low
+
+  * Make the build reproducible by sorting the locales in make.py.
+
+ -- Jérémy Bobbio <lunar@debian.org>  Thu, 25 Dec 2014 16:06:03 +0000
+
 lightproof (1.5+git20140515-1) unstable; urgency=low
 
   * new upstream snapshot 
diff -Nru lightproof-1.5+git20140515/debian/patches/output_locales_in_sorted_order.diff lightproof-1.5+git20140515/debian/patches/output_locales_in_sorted_order.diff
--- lightproof-1.5+git20140515/debian/patches/output_locales_in_sorted_order.diff	1970-01-01 00:00:00.000000000 +0000
+++ lightproof-1.5+git20140515/debian/patches/output_locales_in_sorted_order.diff	2014-12-25 16:49:09.000000000 +0000
@@ -0,0 +1,22 @@
+Description: Output locales in sorted order
+ To make the package build reproducibly, we output the list of locales
+ in sorted order.
+Author: Jérémy Bobbio <lunar@debian.org>
+
+--- lightproof-1.5+git20140515.orig/make.py
++++ lightproof-1.5+git20140515/make.py
+@@ -2,11 +2,13 @@
+ import sys, os, zipfile, traceback, Dialog
+ import configparser as cp
+ import pythonpath.lightproof_compile___implname__
++from collections import OrderedDict
++import json
+ from string import Template
+ 
+ def dist(fn, a):
+     a['locales'] = a["locales"].replace("_", "-")
+-    a['loc'] = str(dict([[i, [i[0:2], i[3:5], ""]] for i in a["locales"].split(" ")]))
++    a['loc'] = json.dumps(OrderedDict([[i, [i[0:2], i[3:5], ""]] for i in sorted(a["locales"].split(" "))]))
+     distname = a['implname'] + "-" + a['version'] + '.oxt'
+     z = zipfile.ZipFile(distname, mode='w', compression = zipfile.ZIP_DEFLATED)
+     f = open(fn + ".dat", 'r', encoding="utf-8")
diff -Nru lightproof-1.5+git20140515/debian/patches/series lightproof-1.5+git20140515/debian/patches/series
--- lightproof-1.5+git20140515/debian/patches/series	1970-01-01 00:00:00.000000000 +0000
+++ lightproof-1.5+git20140515/debian/patches/series	2014-12-25 16:08:47.000000000 +0000
@@ -0,0 +1 @@
+output_locales_in_sorted_order.diff

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
Source: lightproof
Source-Version: 1.6-2

We believe that the bug you reported is fixed in the latest version of
lightproof, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 773919@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rene Engelhard <rene@debian.org> (supplier of updated lightproof package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 11 Sep 2019 18:22:54 +0200
Source: lightproof
Architecture: source
Version: 1.6-2
Distribution: unstable
Urgency: medium
Maintainer: Debian LibreOffice Maintainers <debian-openoffice@lists.debian.org>
Changed-By: Rene Engelhard <rene@debian.org>
Closes: 773919 917686
Changes:
 lightproof (1.6-2) unstable; urgency=medium
 .
   * apply patch from Jérémy Bobbio <lunar@debian.org> to output locales in a
     stable order to make the build reproducible (Closes: #773919)
   * add upstream patch to fix build with python 3.7 (closes: #917686)
Checksums-Sha1:
 95f93dcc7fd58ee9dbdc541a31232a684f3fd234 2007 lightproof_1.6-2.dsc
 25aab382bdb1f9246d5f8ba9009e09cb28c5a713 3972 lightproof_1.6-2.debian.tar.xz
 4281b5e2e2f056cfa8e811b82284e6d0e4eaa224 5647 lightproof_1.6-2_source.buildinfo
Checksums-Sha256:
 61e6bf1c2bb4e3db7c1832cd9202db9066647fd7ee8406d735a58261aece8de9 2007 lightproof_1.6-2.dsc
 2483a614a2e931cf98ad22e83c80a2543f9b9d49451abb7b7cf3f353cc03ab74 3972 lightproof_1.6-2.debian.tar.xz
 cfcb94772477eeea20af1c88fa61ffe61b973499bc196e3d9c3201b0b1664bf8 5647 lightproof_1.6-2_source.buildinfo
Files:
 ee2b50edce7df0233ef9deb507d1256a 2007 text optional lightproof_1.6-2.dsc
 2a39195c13fcd8a0f091f66cb7552389 3972 text optional lightproof_1.6-2.debian.tar.xz
 05a90126f60ceeb411aaade4abac945b 5647 text optional lightproof_1.6-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE4S3qRnUGcM+pYIAdCqBFcdA+PnAFAl15IRgQHHJlbmVAZGVi
aWFuLm9yZwAKCRAKoEVx0D4+cHU9D/0clUurxl/cBodqMB59XMwjFqyhFdAj8X6L
PdD/UYDJ4QgJgWyKTdBRapADJf3lad52+LW9xJErPiRXVDyNhhioQKrpcoDQFqlH
Jiz16MWXlGtGZRs6KbnOwRf+tF/aqqBsYO/yRUzEoF/cLeiGeoQZyKO9lt12cqDT
S3xTNjlZwhs6GXxksLXur1ZuBAwTppmExm7JJ10GV0pYsQDIYxf+oR/hwp+92HE/
mx0H3jqcXqhbBBrduocVEUo7mU01c5JlZrkBysgrdjuDObRU9HO98XNmZ64UP4fL
sQlINRv/fGqtamlTETnCkhYCLhUz7Y2MfhGc/GlgfK/AA5ziOKe5y1Ldwrud0l4g
+YPa6fL0rJ4qPHaTM9a2fqPsH9oSL7JB/ayYuVOdH//CE0u7HW5axKooHXhOW1p4
vlxJPHQCSBVdM/oP08j7Jy2afAKsQ0bJqoz06HXGSqFz4Oe+UL8cpi+QR9DEqiFx
ycXGJbqCTvca8gkkGhhLUX3r+U6upLG9ukGOM7h6WGLLilQBhvjJFoe6vMfT6VtM
P7itgPEbJhNhC7nG052HGERnLRFJad+XLUG215giolI4SrPdTWObwiMzdvpUt/HI
Hj/7oKLEUf/bYC9ccRmD8I87/TwhhZ4QRbqvEAhr1V7haqhSwPAG/0lGGlwKt7Jl
BLArIwyt/w==
=xNSP
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: