[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#925200: missing warning for wrong path



Thanks, I'll take a look. 

On Thu, Mar 21, 2019 at 10:11 AM Osamu Aoki <osamu@debian.org> wrote:
control: retitle -1 check doc-base-file-references-wrong-path
control: tags -1 + patch

Excuse me, lintian warning was correct.

But after checking this bug of mine, I came up with a possible
improvement for the lintian check.  I made a proof-of-concept patch
here.

Package: lintian
Version: 2.11.0
Severity: normal

Requested action for /usr/share/lintian/checks/menus.pm:
========================================================

   * add sanity check for the file path to be usr/share/doc/*
     or /usr/share/info/*.
     --> /usr/share/lintian/checks/menus.pm before line 353
         add file path matching rule and produce error message as
         needed.

Attached a proof of concept patch:

Note:
I didn't run perltidy since that changed many other parts.

I still didn't figure out how the test suite within lintian works.
This code is tested by installing it to the target pat manually ;-)

Osamu

PS: I at least see that libreoffice-help-en-us should fail this new
test.  It shouldn't list /usr/share/libreoffice/help/media/* which is
outside of /usr/share/doc/*.  Instead, it should create symlink using
dh_link:
  /usr/share/doc/<package>/help -> /usr/share/libreoffice/help
Then use this new path for doc-base.

PS sixerjman: I think your concern is addressed with lintian now.

Reply to: