Bug#814968: hunspell: diff for NMU version 1.3.3-3.1
Hi,
On Wed, Mar 09, 2016 at 11:08:45AM -0800, Raúl Benencia wrote:
> On Wed, Mar 09, 2016 at 05:43:55PM +0100, Rene Engelhard wrote:
> > > I've prepared an NMU with this changes (versioned as 1.3.3-3.1).
> >
> > Erm, without givinbg the maintainer the chance to add the fix himself? That's not how
> > NMUs are supposed to work.
>
> I'm going to quote the developer reference, section 5.11.1:
>
> | Unless you have an excellent reason not to do so, you must then give some
> | time to the maintainer to react (for example, by uploading to the
> | DELAYED queue). Here are some recommended values to use for delays:
> |
> | (...)
> |
> | * Upload fixing only release-critical bugs older than 7 days: 2 days
>
> This release-critical bug has been open for more than twenty days, so I
Yes, it was open for > 20 days.
But if you actually read the bug carefully you'd have seen that I forwarded
this to upstream _yesterday_. Because I only reached him yesterday given he
wasn't on IRC before.
That was the last action. And you can't expect debugging go that fast for busy
upstreams.
Then today your patch came. Thanks for that :)
> understand that this is how NMUs are supposed to work.
Interestingly, in your above quote you don't quote
- Did you give enough time to the maintainer? When was the bug reported to the BTS? Being busy for a week or two isn't unusual. Is the bug so severe that it needs to be fixed right now, or can it wait a few more days?
and
- If the maintainer is usually active and responsive, have you tried to contact them? In general it should be considered preferable that maintainers take care of an issue themselves and that they are given the chance to review and correct your patch, because they can be expected to be more aware of potential issues which an NMUer might miss. It is often a better use of everyone's time if the maintainer is given an opportunity to upload a fix on their own.
I am active. And see the first paragraph above.
And if that bug is fixed there's other bugs which didn't warrant an other
upload which could be (and were now) fixed with the same upload.
> | It is sometimes useful to upload a package immediately, but to want this
> | package to arrive in the archive only a few days later. For example, when
> | preparing a Non-Maintainer Upload, you might want to give the maintainer
> | a few days to react.
>
> I've used mentors as a replacement of DELAYED in hopes that, if you were
> unresponsive for the aforementioned time, another DD could have easily
> sponsored the NMU.
>
> Would you care to explain why do you think I shouldn't have hypothetically
> used DELAYED in this way?
You should have sent the diff and I would have added it quickly. There's
no need to "threaten" with a NMU.
Anyway, thanks for the patch. Told upstream and uploaded the fixed package.
Regards,
Rene
Reply to: