[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#780253: Re Bug #780253 - libreoffice-writer: LibreOffice has no support for Google Drive



Hi,

On Thu, Feb 25, 2016 at 12:38:30AM +0100, Stéphane Aulery wrote:
> Le 24/02/2016 23:41, Rene Engelhard a écrit :
> >On Wed, Feb 24, 2016 at 07:12:17PM +0100, Stéphane Aulery wrote:
> >Or I misunderstand the concept of a "secret" here, but I doubt that.
> >
> >That said, I see that chromium-browser in Debian also has a debian/apikeys...
> 
> Ok, forget that. No way to spread this kind of thing!

Well, actually it is "worse", which makes this actually fixable :)

As said, there's debian/apikeys in the chromium source package *and* it even
is installed to /etc/chromium.d/apikeys.
This was added back in 2014 with https://bugs.debian.org/748867 - so
the "Debian Google secrets" are available already.

Actually I discussed that this night  in #debian-devel (tone: "well, API keys,
whatever" and with the chromium maintainer (tone: "you can use it, it's in
/etc/chromium.d/apikeys - maybe you should ask google for permission but I
don't have a problem with that"

We could use those.

Will ask Google for permission.

And if that works, the patch is even more simple, we don't even need to
copy it over ;)

diff --git a/rules b/rules
index e4d30e8..d1baef8 100755
--- a/rules
+++ b/rules
@@ -430,6 +430,12 @@ LIBCMIS_MINVER=0.5.0-3
 else
 LIBCMIS_MINVER=0.5.0
 endif
+ifeq "$(DEB_VENDOR)" "Debian"
+# Google API stuff for GDrive access
+BUILD_DEPS += chromium (>= 39.0.2171.71-1)
+include /etc/chromium.d/apikeys
+CONFIGURE_FLAGS += --with-gdrive-client-id=$(GOOGLE_DEFAULT_CLIENT_ID) --with-gdrive-client-secret=$(GOOGLE_DEFAULT_CLIENT_SECRET)
+endif
 SYSTEM_STUFF += jpeg
 SYSTEM_STUFF += libxml
 SYSTEM_STUFF += expat

Regards,

Rene


Reply to: