[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#807601: libreoffice-core and libreoffice-evolution still depend on libgtk2.0-0



Hi,

On Thu, Dec 10, 2015 at 09:04:55PM +0100, Rene Engelhard wrote:
> On Thu, Dec 10, 2015 at 07:19:32PM +0100, Emilio Pozuelo Monfort wrote:
> > system, and while at that I noticed that libreoffice-core and
> > libreoffice-evolution depend on libgtk2.0-0.
> > 
> > Binary file pluginapp.bin matches
> > Binary file libpllo.so matches
> 
> This is http://cgit.freedesktop.org/libreoffice/core/tree/extensions/source/plugin/unx?h=libreoffice-5-1 and thus http://cgit.freedesktop.org/libreoffice/core/tree/extensions/Executable_pluginapp.bin.mk?h=libreoffice-5-1 and http://cgit.freedesktop.org/libreoffice/core/tree/extensions/Library_pl.mk?h=libreoffice-5-1.
> 
> The (imho uneeded) "use npapi plugins inside LibreOffice" feature....
> 
> Probably depending on gtk2 since "the browsers (read: firefox/icewasel)" do,
> which is wrong noadays. But It uses gtk itself:
> 
> (sid)rene@frodo ..0.0.beta2/extensions/source/plugin/unx % grep -r gtk_ *
> npnapi.cxx:                        pInst->pGtkWindow = gtk_plug_new((GdkNativeWindow)reinterpret_cast<sal_uIntPtr>(pWindow->window));
> npnapi.cxx:                        gtk_widget_show( pInst->pGtkWindow );
> npnapi.cxx:                        pInst->pGtkWidget = gtk_socket_new();
> npnapi.cxx:                        gtk_widget_show( pInst->pGtkWidget );
> npnapi.cxx:                        gtk_container_add( GTK_CONTAINER(pInst->pGtkWindow), pInst->pGtkWidget );
> npnapi.cxx:                        gtk_widget_show_all( pInst->pGtkWindow );
> npnapi.cxx:                        pInst->window.window = reinterpret_cast<void *>(gtk_socket_get_id( GTK_SOCKET(pInst->pGtkWidget ) ));
> npnapi.cxx:                    gtk_widget_set_size_request( pInst->pGtkWidget, pWindow->width, pWindow->height );
> npnapi.cxx:                    gtk_window_resize( GTK_WINDOW(pInst->pGtkWindow), pWindow->width, pWindow->height );
> npnapi.cxx:                    GdkScreen* pGdkScreen = gtk_widget_get_screen( pInst->pGtkWidget );
> npwrap.cxx:        gtk_init(&argc, &argv);
> (sid)rene@frodo ..0.0.beta2/extensions/source/plugin/unx %
> 
> No idea about whether the API used changed between gtk2 and gtk3...

Besides that fact, one might consider splitting this "feature" out or
(but that means implicitely giving it more attention...) or simply patching
it away, I don't really believe anyone is using this ;)

Regards,
 
Rene 


Reply to: