Bug#749592: libreoffice-mysql-connector: doesn't work ignoring server configuration
retitle 749592 libreoffice-mysql-connector: doesn't work with remote connections; ignoring server configuration and always tries socket
thanks
Hi,
On Thu, May 29, 2014 at 10:29:45AM +0200, MAG4 Piemonte wrote:
> > On Wed, May 28, 2014 at 03:37:02PM +0200, MAG4 Piemonte wrote:
> > > Package: libreoffice-mysql-connector
> > > Version: 1.0.2+LibO4.2.4-3
> > > Severity: grave
> > > Justification: renders package unusable
> >
> > Why? How does this render the whole package unusable?
>
> You are right, unusable on remote connections (we can not test locally because Libreoffice is on clients with jessie and MySQL is on server with wheezy) ...
OK
I diffed mysqlc's source from 4.1.6 to 4.2.0 and saw
diff --git a/mysqlc/source/mysqlc_connection.cxx b/mysqlc/source/mysqlc_connection.cxx
index bd9b159..8816cb2 100644
--- a/mysqlc/source/mysqlc_connection.cxx
+++ b/mysqlc/source/mysqlc_connection.cxx
@@ -152,19 +152,19 @@ void OConnection::construct(const OUString& url, const Sequence< PropertyValue >
m_settings.connectionURL = url;
for (;pIter != pEnd;++pIter) {
- if (!pIter->Name.compareToAscii("user")) {
+ if (pIter->Name.equalsAscii("user")) {
OSL_VERIFY( pIter->Value >>= aUser );
- } else if (!pIter->Name.compareToAscii("password")) {
+ } else if (pIter->Name.equalsAscii("password")) {
OSL_VERIFY( pIter->Value >>= aPass );
- } else if (!pIter->Name.compareToAscii("LocalSocket")) {
+ } else if (pIter->Name.equalsAscii("LocalSocket")) {
OSL_VERIFY( pIter->Value >>= sUnixSocket );
unixSocketPassed = true;
- } else if (!pIter->Name.compareToAscii("NamedPipe")) {
+ } else if (pIter->Name.equalsAscii("NamedPipe")) {
OSL_VERIFY( pIter->Value >>= sNamedPipe );
namedPipePassed = true;
- } else if ( !pIter->Name.compareToAscii("PublicConnectionURL")) {
+ } else if ( pIter->Name.equalsAscii("PublicConnectionURL")) {
OSL_VERIFY( pIter->Value >>= m_settings.connectionURL );
- } else if ( !pIter->Name.compareToAscii("NewURL")) { // legacy name for "PublicConnectionURL"
+ } else if ( pIter->Name.equalsAscii("NewURL")) { // legacy name for "PublicConnectionURL"
OSL_VERIFY( pIter->Value >>= m_settings.connectionURL );
}
}
which upstream says is semantically ok but looks related nevertheles... Will try to revert.
Regards,
Rene
Reply to: