Bug#719941: libreoffice-script-provider-python: python 3 porting issues

[Rene Engelhard <rene@debian.org>]

tag 719941 + pending
thanks

Hi,

On Wed, Aug 21, 2013 at 01:41:51AM -0500, Mike Dupont wrote:
> resending because the mail system was confused :
> > On Tue, Aug 20, 2013 at 10:27 AM, Rene Engelhard <rene@debian.org> wrote:
> > -                ret = open( systemPath , "a" )
> > +                ret = file( systemPath , "a" )
> >
> > So why is this needed?
> see http://docs.python.org/release/3.0/whatsnew/3.0.html#builtins file is
>  removed, you must used open

Hmm. Indeed.

And:

09:52 <@_rene_> mst_:
09:52 <@_rene_> > So why is this needed?
09:52 <@_rene_> see 
                http://docs.python.org/release/3.0/whatsnew/3.0.html#builtins 
                file is
09:52 <@_rene_> removed, you must used open
09:54 -!- timar [~chatzilla@5401C5A0.dsl.pool.telekom.hu] has joined 
          #libreoffice-dev
09:54 -!- mode/#libreoffice-dev [+o timar] by ChanServ
09:57 < mst_> _rene_, ahh i see the bug report has the patch inverted :)
09:57 < mst_> _rene_, yes makes sense feel free to commit it
09:58 < mst_> vmiklos, in case nobody pinged you yet there's some first-page 
              patches in gerrit that quickly need reviewing
09:58 <@sberg> off to Wilhelmsburg...
09:58 -!- sberg [~sbergman@dslb-092-076-090-155.pools.arcor-ip.net] has quit 
          [Quit: Leaving]
09:58 <@_rene_> mst_: where we are back to the initial question. with a version 
                check or just like this and scratch python2 support for the 
                script provider?
09:59 < mst_> vmiklos, also please don't push them out-of-order via gerrit as 
              pmladek did that in 4-0 branch and it resulted in an undetected 
              merge conflict and a duplicated line
09:59 <@vmiklos> mst_: yep, will do it as soon as my build finishes here
09:59 < mst_> _rene_, python2 should supports open() too
10:00 <@vmiklos> ok, thanks for the warning :)
10:02 <@_rene_> Constructor function for the file type, described further in 
                section File Objects. The constructor's arguments are the same 
                as those of the open() built-in function described below.
10:02 <@_rene_> (http://docs.python.org/2/library/functions.html#file)
10:02 <@_rene_> ah, yeah

Thus I committed

http://cgit.freedesktop.org/libreoffice/core/commit/?id=83f4be4740892e497d30f660abb55e40c628158e

The bug is pending now because it will be in 4.2 ion February, but I might
backport it to 4.1.x...

Regards,

Rene