[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#706346: graphite2: FTBFS on powerpcspe (failed test due to rounding issue)



tag 706346 - upstream
tag 706346 - sid
tag 706346 + wontfix
thanks

On Sun, Apr 28, 2013 at 06:15:22PM +0200, Roland Stigge wrote:
> Version: 1.1.3-1
> Severity: wishlist
> Tags: sid upstream

No, not upstream. You said that yourself.

> I.e. a rounding issue leading to "-0.0" instead of expected "0.0". This happens
> in gr2fonttest/gr2FontTest.cpp:688 where an fprintf() prints a float via %6.1f
> and actually has sth. like -0.00xxx in float orgX.
> 
> So I'm wondering if we are strictly looking for an orgX value of >0.00... here,
> or if we accept a rounding tolerance of small values -0.1 < x < 0. In the

Wait. You basically say "my port has a rounding bug but please lower precision
in your font rendering package so that it works"? I doubt that should be done.

Fix the port.

Or is that "rounding" issue a problem in graphite2s code?

> former case, we would need to fix powerpcspe float rounding somehow. In the
> latter case, a more relaxed rounding tolerance in gr2fonttest/gr2FontTest.cpp
> would be best.

Well, it's a font rendering, so precision out to be important, no?

> As the maintainer (or upstream), you have a better understanding what's
> appropriate here. Depending on your decision, I can try to provide a
> patch.

I don't think it makes sense to do so until powerpcspe does rounding
correctly?

(Not that upstream cared about armel and sparc FTBFSing either - and
those are FAR MORE important than powerpcspe...)

> (This issue also applies to graphite2_1.2.1-1 in experimental.)   

So the sid tag is not correct...

Regards,

Rene


Reply to: