Bug#543652: Error is from a missing exit in open-url

[Anthony DeRobertis <anthony@derobert.net>]

Package: openoffice.org-common
Version: 1:3.1.1-2
Severity: normal
File: /usr/lib/openoffice/basis3.1/program/open-url

Here is the bit of code in open-url for non-mailto: URIs:

else
  # check $BROWSER variable
  if [ ! -z "$BROWSER" ]; then
    $BROWSER "$1" &
    exit 0                                             <--
  elif [ -x /usr/bin/sensible-browser ]; then
    sensible-browser "$1"
  else
    # mozilla derivates may need -remote semantics
    for i in firefox mozilla netscape; do
      browser=`which $i`
      if [ ! -z "$browser" ]; then
        run_mozilla "$browser" "$1"
        exit 0                                         <--
      fi
    done
    # handle all non mozilla browers below
    # ..
  fi
fi
exit 1

Notice that both the $BROWSER and firefox/mozilla/netscape case have an
exit statement. The sensible-browser case is missing it. It should
probably be:

  elif [ -x /usr/bin/sensible-browser ]; then
    sensible-browser "$1"
    exit $?

Also, 'iceweasel' and 'iceape' really ought to be added to the list of
mozillas.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable'), (100, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.31-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages openoffice.org-common depends on:
ii  openoffice.org-style-galaxy   1:3.1.1-2  full-featured office productivity 

Versions of packages openoffice.org-common recommends:
ii  openoffice.org-style-crystal  1:3.1.1-2  full-featured office productivity 
ii  openoffice.org-style-oxygen   1:3.1.1-2  full-featured office productivity 
ii  openoffice.org-style-tango    1:3.1.1-2  full-featured office productivity 
ii  xfonts-mathml                 3          Type1 Symbol font for MathML

Versions of packages openoffice.org-common suggests:
ii  openoffice.org-style-hicontra 1:3.1.1-2  full-featured office productivity 
ii  openoffice.org-style-industri 1:3.1.1-2  full-featured office productivity 

-- no debconf information

-- debsums errors found:
debsums: changed file /var/lib/openoffice/basis3.1/share/config/javasettingsunopkginstall.xml (from openoffice.org-common package)