[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#520611: openoffice.org: package synopsis should not repeat package name



tag 520611 - patch
thnks

Ben Finney wrote:
> --- control.debug.in	2009-03-20 19:33:13 +0000
> +++ control.debug.in	2009-03-21 10:25:37 +0000
> @@ -4,7 +4,7 @@
>  Priority: extra
>  Depends: ${misc:Depends}
>  Suggests: ${dbg-dbg-suggests}
> -Description: OpenOffice.org debug symbols
> +Description: full-featured office productivity suite - debug symbols
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .

Why should we be not allowed ro refer to Openoffice.org in the deescription,
It's well known. Instead of adding everwhere the "full-featured office productivity suite"
bogusly. (I can understand that for the core modules of openoffice.org, but not for debug,
SDK ("OpenOffice.org SDK" is an own product by Su, though build from OOo source) and the extensions
(report-builder officially is called "Sun Report Builder". That's not better than the current description, is it?)

Other comments inline.

> === modified file 'control.fonts.in'
> --- control.fonts.in	2009-03-20 19:33:13 +0000
> +++ control.fonts.in	2009-03-21 10:25:37 +0000
> @@ -4,7 +4,7 @@
>  Replaces: openoffice.org (<= 1.1.1+1.1.2rc3)
>  Depends: ${misc:Depends}
>  Recommends: fontconfig
> -Description: The OpenSymbol TrueType font
> +Description: OpenSymbol TrueType font
>   This package contains the OpenSymbol TrueType font included in
>   OpenOffice.org. This font contains symbols (like fonts as Wingdings(tm)),
>   bullets (needed for bullets in OpenOffice.org) and non-latin character

OK

> === modified file 'control.gcj.in'
> --- control.gcj.in	2009-03-20 19:33:13 +0000
> +++ control.gcj.in	2009-03-21 10:25:37 +0000
> @@ -7,7 +7,7 @@
>   ${java-gcj-depends},
>   ${misc:Depends}
>  Enhances: openoffice.orgVER-writer, openoffice.orgVER-base
> -Description: OpenOffice.orgs Java libraries (native for use with GIJ)
> +Description: full-featured office productivity suite - Java libraries for GIJ
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .
> 
> === modified file 'control.help.in'
> --- control.help.in	2009-03-20 19:33:13 +0000
> +++ control.help.in	2009-03-21 10:25:37 +0000
> @@ -7,7 +7,7 @@
>  Conflicts: openoffice.org-common (<= 2.0.0-1), 
>   openoffice.org-core (<< ${base-version})
>  Provides: openoffice.org-help-${help-l10n-virtual-version}
> -Description: @LNAME@ help for OpenOffice.org
> +Description: full-featured office productivity suite - @LNAME@ help
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .
> 
> === modified file 'control.in'
> --- control.in	2009-03-21 09:14:30 +0000
> +++ control.in	2009-03-21 10:25:37 +0000
> @@ -98,7 +98,7 @@
>  Conflicts: openoffice.org2 (<< ${binary:Version}), openoffice.orgVER-java-common (<< 1:3.0.0)
>  Replaces: openoffice.org2 (<< ${binary:Version}), openoffice.org-debian-files
>  Provides: openoffice.org2
> -Description: OpenOffice.org Office suite
> +Description: full-featured office productivity suite
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .
> @@ -146,7 +146,7 @@
>  Architecture: all
>  Depends: openoffice.orgVER, openoffice.orgVER-l10n-pt-br, openoffice.orgVER-help-pt-br, myspell-pt-br,
>   ${misc:Depends}
> -Description: BrOffice.org office suite
> +Description: full-featured office productivity suite - Brazilian edition
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .

This os not a Brazlian edition. The name of the program simply is broffice.org. What will you propose
when we once split vanilla and go-oo?

Description: full-featured office productivity suite -  foobar
Description: full-featured office productivity suite - Go-OO Version - foobar

for *all* packages?

Thus having three or even more packages with the same Description there?

> --- control.mediawiki.in	2009-03-20 19:33:13 +0000
> +++ control.mediawiki.in	2009-03-21 10:25:37 +0000
> @@ -6,7 +6,7 @@
>   ${misc:Depends}
>  Enhances: openoffice.orgVER-writer
>  Suggests: mediawiki
> -Description: OpenOffice.org Wiki Publisher extension
> +Description: full-featured office productivity suite - wiki publisher
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .

This loosed the info that it's an extension. And normally not distributed
within OOo. We just package it because we get it as by-product of the build.

The same for all the other extensions.

> @@ -13,7 +13,7 @@
>  Conflicts: libuno-cil, libuno-cli-types1.1-cil
>  Provides: libuno-cil
>  Replaces: libuno-cil
> -Description: CLI binding for OpenOffice.org
> +Description: full-featured office productivity suite - CLI binding
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .

As asked at the top, what is bad in referring to OpenOffice.org here? The
description does not begin with "OpenOffice.org"...

> === modified file 'control.qa.in'
> --- control.qa.in	2009-03-20 19:33:13 +0000
> +++ control.qa.in	2009-03-21 10:25:37 +0000
> @@ -12,7 +12,7 @@
>  Conflicts: openoffice.org-core (<< 1:2.3.0~oog680m2)
>  Replaces: openoffice.org-common (<< 2.0.4~ood680m2)
>  Architecture: %OOO_QA_ARCHS%
> -Description: OpenOffice.org Automatic Test Programs
> +Description: full-featured office productivity suite - automated tests

Wrong. No tests there. Just test *rpograms*.

>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .
> @@ -28,7 +28,7 @@
>  Priority: extra
>  Depends: openoffice.orgVER-qa-tools, ${java-runtime-depends}
>  Architecture: all
> -Description: OpenOffice.org API Test Data
> +Description: full-featured office productivity suite - automated test data
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .
> 
> === modified file 'control.reportdesign.in'
> --- control.reportdesign.in	2009-03-20 19:33:13 +0000
> +++ control.reportdesign.in	2009-03-21 10:25:37 +0000
> @@ -7,7 +7,7 @@
>  Replaces: openoffice.org-reportdesigner
>  Provides: openoffice.org-reportdesigner
>  Enhances: openoffice.orgVER-base
> -Description: OpenOffice.org Report Builder extension
> +Description: full-featured office productivity suite - report builder
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .

This is the "Sun Report Builder" extension...

> @@ -23,7 +23,7 @@
>  Architecture: %OOO_JAVA_ARCHS%
>  Depends: ${shlibs:Depends}, openoffice.org-core (>> 1:2.3.0~oog680m1), openoffice.orgVER-base (>= 2.3.0~src680m225)
>  Replaces: openoffice.orgVER-report-builder
> -Description: OpenOffice.org Report Builder extension - support libraries
> +Description: full-featured office productivity suite - report builder libraries
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .

.. and report-builder libraries is misleading imho. it's a no-op when the SRB extension
is not installed.

> === modified file 'control.sdk.in'
> --- control.sdk.in	2009-03-20 19:33:13 +0000
> +++ control.sdk.in	2009-03-21 10:25:37 +0000
> @@ -19,7 +19,7 @@
>   openoffice.org-dev-doc (<< 2.0.2-4)
>  Conflicts: openoffice.org-debian-files, openoffice.org2-dev
>  Provides: openoffice.org2-dev
> -Description: OpenOffice.org SDK -- development files
> +Description: full-featured office productivity suite - development files
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .
> @@ -38,7 +38,7 @@
>   openoffice.org2-dev-doc
>  Provides: openoffice.org2-dev-doc
>  Conflicts: openoffice.org2-dev-doc
> -Description: OpenOffice.org SDK -- documentation
> +Description: full-featured office productivity suite - development documentation
>   OpenOffice.org is a full-featured office productivity suite that provides
>   a near drop-in replacement for Microsoft(R) Office.
>   .

See the top.

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  rene@debian.org | GnuPG-Key ID: 248AEB73
   `-   Fingerprint: 41FA F208 28D4 7CA5 19BB  7AD9 F859 90B0 248A EB73




Reply to: