Bug#501664: openoffice.org-common: sh script syntax error prevents application start + bashism

[Kel Modderman <kel@otaku42.de>]

Package: openoffice.org-common
Version: 1:2.4.1-10
Severity: important
Usertags: goal-dash

When attempting to start an oo application:

$ oowriter
/usr/lib/openoffice/program/soffice: 367: Syntax error: "fi" unexpected (expecting "done")

Which is caused by a for loop ending with `fi' and not `done'.

Additionally, there is a bashism:

$ checkbashisms /usr/lib/openoffice/program/soffice
possible bashism in /usr/lib/openoffice/program/soffice line 379 (alternative test command ([[ foo ]] should be [ foo ])):
if [[ -f $dialog_xlc && -f $script_xlc ]]; then

Which could be:
if [ -f "$dialog_xlc" ] && [ -f "$script_xlc" ]; then

Thanks, Kel.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-5.slh.12-sidux-amd64 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages openoffice.org-common depends on:
ii  dictionaries-common [openoffi 0.98.12    Common utilities for spelling dict
ii  openoffice.org-style-andromed 1:2.4.1-10 Default symbol style for OpenOffic

Versions of packages openoffice.org-common recommends:
pn  openoffice.org-style-crystal  <none>     (no description available)
pn  openoffice.org-style-tango    <none>     (no description available)

Versions of packages openoffice.org-common suggests:
pn  openoffice.org-style-hicontra <none>     (no description available)
pn  openoffice.org-style-industri <none>     (no description available)

-- no debconf information