[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#373224: Recognize automagically the digital signature from mozilla



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[ Hmm. Somehow this never reached d-openoffice... ]

Hi,

José L. Redrejo Rodríguez wrote:
> I'm not a perl programmer, so I'm sure the patch can be improved by some perl guru, but it works.

See inline comments.

> +if ( ! exists $ENV{MOZILLA_CERTIFICATE_FOLDER} )
> +{
> +	$mozilla_default_db="";
> +	if ( -d "$ENV{HOME}/.firefox" ) {
> +		$mozilla_default_db=`find $ENV{HOME}/.firefox -name 'cert8.db'`;
> +	}

There's no .firefox here. There's only .mozilla/firefox

> +	if ( $mozilla_default_db eq "" ) {
> +		if ( -d "$ENV{HOME}/.mozilla" ) {
> +		$mozilla_default_db=`find $ENV{HOME}/.mozilla -name 'cert8.db'`;
> +		}
> +	}

mozilla is here (containing .mozilla/firefox and .mozilla/default).

In this case you have a problem when you use(d) both mozilla and
firefox. Which one will be used? I think it's better looking in
mozilla/default...

> +	if (! $mozilla_default_db eq "" ) { 
        if ( $mozilla_default_db ne "" ) {

;)

A related question: Does signing then actually work? Or does it crash
when you try to actually sign?

Regards,

Rene
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEwq13+FmQsCSK63MRAmAgAJ9Ea2EPrl2CIoIxAmKNXZSEAeVsyACcC2qs
ek5k6M9UWH1zfqUpCAKAYQE=
=L6ma
-----END PGP SIGNATURE-----



Reply to: