[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: CVS:oo-deb/debian changelog,1.349,1.350 rules,1.220,1.221



Hi,

Josh Triplett wrote:
> Rene Engelhard wrote:
> > +	ifeq "$(PATCHSET)" "DebianWoody"
> > +		# hack to remove fontconfig dependency on woody backports
> > +		perl -pi -e 's/(Depends: ).*fontconfig(.*)/\1\2/' \
> > +			debian/ttf-opensymbol/DEBIAN/control
> > +	endif
> 
> I don't think this will do what you want.  If fontconfig is not the
> first entry in the list, then this will remove all dependencies before
> fontconfig.  And if fontconfig is not the last entry in the list, then

Hmm. Yes. Looks like I wrote this with the current line in mind
in which fontconfig is the only (and first) entry...

> this does not remove the comma after fontconfig.  This leaves the
> possibility that fontconfig is the _only_ entry in the list (so it can
> be both first and last), which would leave an empty "Depends:" line.

Depends: , fontconfig

and

Depends:

works. I tested it (although with sid's dpkg..)

> Better to just use a substvar, which would solve these problems
> automatically.

Yes, probably...

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  rene@debian.org | GnuPG-Key ID: 248AEB73
   `-   Fingerprint: 41FA F208 28D4 7CA5 19BB  7AD9 F859 90B0 248A EB73
      

Attachment: signature.asc
Description: Digital signature


Reply to: