[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

libmspack's debian/



Hi,

OOo is going to use libmspack in one of their next versions as it seems
[1]. So I checked out the CVS (as you told Kevin) to look over it.

Sorry, but the debian/ directory is seriously broken.

It

  a) names the package libmyspack while Debian policy requires splitting
     the package into libspackSONAME and libmspack-dev. Since there is
     no shared library here the package should produce libmspack-dev
     containg the headers and the static library.
     So or so libmspack is wrong.

  b) nothing is installed into the deb anywhere except usr/share/doc/...

  c) debian/copyright is missing

  d) has oudated DH_COMPAT and Standards-Version:

debian/ is CVS is IMHO a BAD IDEA anyhow, since that quickly gets out of
sync. The coresponding Debian packager could have debian/ in his CVS
anyhow or something...

A bug in the configure script is that CFLAGS in the environment isn't
honoured. That's necessary for Debian policy since we have to build with
-g during build anyhow and strip later and we should support easy
switching between -O0 and -O2 in debian/rules via an envvar.

The diff attached here fixes at least the debian/ stuff and cleans some
stuff out... Markus, if you really want to maintain libmspack you probably have to RTFMs more.
And depending on whether Kevin wants to integrate it into OOo 1.1.1, we need
it in Debian unstable relatively soon... [2]

[1] as posted on dev@porting.openoffice.org
[2] Debian has the viewpoint that is is better to use an own package
    (in this case libmspack-dev then including all things into the
    OOo source and build it with it....)
    
Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  rene@debian.org | GnuPG-Key ID: 248AEB73
   `-   Fingerprint: 41FA F208 28D4 7CA5 19BB  7AD9 F859 90B0 248A EB73

Attachment: signature.asc
Description: Digital signature


Reply to: