Hi Oliver, On Tue, Dec 26, 2017 at 12:16:50AM +0100, Oliver Heimlich wrote: > Please upload octave-interval 3.1.0-1 to unstable. > > I have successfully build the package locally using: > $ dpkg-buildpackage -us -uc > > Further testing / reviewing is appreciated, since I am not that familiar > with the Debian packaging tools. ;-) > > This revision fixes several problems: > - Contains the latest upstream version 3.1.0 > - Bug 874135 has been fixed upstream (compile flags) > - Bug 877149 has been fixed upstream (OSMesa removed) > - It should no longer be required to fix the build (d/patches) A few points to be fixed: 1) You forgot to close the two bugs in the changelog entry, using the "(Closes: #nnnnnn)" magic. Since the bugs have been fixed by the new upstream release (and not by a Debian-specific patch or a packaging change), you should add two sub-entries under "New upstream release" with a short comment for each and the "Closes" magic. 2) I get the following lintian messages/warnings related to debian/copyright: I: octave-interval source: wildcard-matches-nothing-in-dep5-copyright ./inst/test/c-xsc.tst (paragraph at line 39) I: octave-interval source: wildcard-matches-nothing-in-dep5-copyright ./test/c-xsc.itl (paragraph at line 39) W: octave-interval source: field-name-typo-in-dep5-copyright file -> files(line 85) I: octave-interval source: wildcard-matches-nothing-in-dep5-copyright ./src/crlibm/scs_lib/tests/zero_scs.c (paragraph at line 128) 3) Please bump to debhelper compat level 11, which has just become the new recommended level (you should change debian/compat and also the debhelper dependency in debian/control). Otherwise the packaging looks good. Thanks for your work, -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ http://sebastien.villemot.name ⠈⠳⣄⠀⠀⠀⠀ http://www.debian.org
Attachment:
signature.asc
Description: PGP signature