[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-octave-devel] Bug#778458: marked as done (please strip times from generated doc-cache)

Your message dated Wed, 18 Feb 2015 16:51:34 +0000
with message-id <E1YO7qY-00038E-LC@franck.debian.org>
and subject line Bug#778458: fixed in octave-pkg-dev 1.2.0
has caused the Debian Bug report #778458,
regarding please strip times from generated doc-cache
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
778458: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778458
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: octave-pkg-dev
Version: 1.1.3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps

Hi!

While working on Debian's “reproducible builds” effort [1], we have
noticed that none of the octave-* packages build reproducibly.
Octave, by default, writes a timestamp to (at least) the doc-cache
file output by the "pkg install" action.

The attached patch prevents this.

It will, however, change the output of all calls to the save function.
I do not know if this will be a problem, or if this matters in practice.

Possible alternative fixes:
 * Don't ship the doc-cache?  Octave recommend shipping it. #37542 [2]
 * Call save_header_format_string at a narrower scope, to ensure it only
      changes the doc-cache.
      install.m -> generate_lookfor_cache.m -> doc_cache_create.m.
 * Make it possible for packages to opt-in to this fix (environment
      variable, perhaps?)

Regards,
 Chris

 [1]: https://wiki.debian.org/ReproducibleBuilds
 [2]: https://savannah.gnu.org/bugs/?37542


--- a/octave-pkg.mk	2015-02-15 10:50:58.851375767 +0000
+++ b/octave-pkg.mk	2015-02-15 10:53:58.556258122 +0000
@@ -92,6 +92,8 @@
 		      [pwd(),'/$(debpkg)/$(bpath)']);			\
 		 pkg ('local_list', [pwd(),'/$(local_list)']);		\
 		 pkg ('global_list', [pwd(),'/$(global_list)']);	\
+		 save_header_format_string(				\
+		  '# Generated by Octave during Debian package build');	\
 		 if (exist ('PKG_ADD.bak') == 2),			\
 		     movefile ('PKG_ADD.bak', 'PKG_ADD');		\
 		 endif;							\

--- End Message ---
--- Begin Message --- 
Source: octave-pkg-dev
Source-Version: 1.2.0

We believe that the bug you reported is fixed in the latest version of
octave-pkg-dev, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 778458@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rafael Laboissiere <rafael@laboissiere.net> (supplier of updated octave-pkg-dev package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 15 Feb 2015 19:36:26 -0200
Source: octave-pkg-dev
Binary: octave-pkg-dev
Architecture: source all
Version: 1.2.0
Distribution: experimental
Urgency: low
Maintainer: Debian Octave Group <pkg-octave-devel@lists.alioth.debian.org>
Changed-By: Rafael Laboissiere <rafael@laboissiere.net>
Description:
 octave-pkg-dev - infrastructure to build Octave packages
Closes: 778458
Changes:
 octave-pkg-dev (1.2.0) experimental; urgency=low
 .
   * octave-pkg.mk:
     + Prevent timestamp in generated doc-cache files.  This ensure
       that doc-cache files are built reproducibly.  Thanks to Chris
       West for the patch (Closes: #778458).
     + Allow exclusion of files from the automatic run of test blocks
   * Bump to Standards-Version 3.9.6, no changes needed
Checksums-Sha1:
 e0469f49ae800cca97e86cac51a30f127013bc78 1767 octave-pkg-dev_1.2.0.dsc
 5f20e168bfc0d66d4482d67435617dbe63d55802 11528 octave-pkg-dev_1.2.0.tar.xz
 73474302395a1622421e3686e6c9c1e07f694eb7 15838 octave-pkg-dev_1.2.0_all.deb
Checksums-Sha256:
 757086d1551fb51b8156905f2c6695f7da7e0597bb4bbb99b3d84662e61cbe0f 1767 octave-pkg-dev_1.2.0.dsc
 c1d71b2f718557165ebd4b665ba8ac682c3f10a8b616b51efd7621387b76b02d 11528 octave-pkg-dev_1.2.0.tar.xz
 a1e9c5edca0ae2bf2f95c5f36119698027b9a9d3bed63cd441ceb61311a61cd0 15838 octave-pkg-dev_1.2.0_all.deb
Files:
 16fb56d2b89c072f5854b97029865168 1767 devel optional octave-pkg-dev_1.2.0.dsc
 668bb780246a724017b40d167b7e1220 11528 devel optional octave-pkg-dev_1.2.0.tar.xz
 66598022a72a82c68dfba361abb46771 15838 devel optional octave-pkg-dev_1.2.0_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJU5L9dAAoJECzs6TUOzr5KfEUP/idZAdK9VFsMHA4eOCvLPBac
jGd9pwHBf80xsdGsKdF1YQChV4KcIR2/M7Zuuag32r3UQ5/lLp1BUdJ/5q5cJn5q
yZ1KDpgnxe67lg58XCgyoyr+izinNAiLbTGatJxeAUmqdRS2LhhwSvVkuUGE1TzP
Z/xqbVTBpGh0lkqCsAGISUcjECbDv+EJVj8HJUCtsOsYVNi9QoWmMmbgu2wxGj4z
QORo8jwJBSyT8xa1odPcmonSehg7qC5U7CJezNxvel4/119PgOnDXzhm4Gd2cTou
hTnz2oTqz6Ca2s0Kg/lQmJB31N/d7VHMAFL1UNPkYhFxAFnDyuObA5AKREevBsE2
1qZdmEKa4RAAmQYtKzotsV8AltOL3vLZUsoYfH4ssQB92TgjfGquUgiOTaWafUZ6
1MuISQPzbnRw4oeu3hTAe2MZXCVm0m8QJAUYKrXoa77xt86Z2/Yqle7DU3+GPy/X
0RN9WpQVvSj6ae0ongrM9tSfX+TTcj1F5Fdpn8cIu7AYZFiQKCZoPL0ELrEsz8my
SOAgFN4ojxcxCduf/pg800HFOgsIECzkWf3G+TMuxJ/Ur2xf+46XmCNw34UMoUEw
pEmOConB8uoRI5inb0p8hwFm9IfJP989nInoTSkSo29yLub0XaZ4yGzftAfF3iAY
3Igk6lS47Zt07IwzDlYF
=+h7A
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: